Update test to enhance code coverage #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
galin-chung-nguyen
commented
Feb 11, 2025
galin-chung-nguyen
commented
- Fix Swap instruction impl in machine.rs
- Fix memory layout allocation in config.rs
chiro-hiro
reviewed
Feb 14, 2025
zkmemory/src/config.rs
Outdated
| } | ||
|
|
||
| #[cfg(test)] | ||
| mod tests { | ||
| use super::ConfigArgs; | ||
| use crate::base::{Base, B256}; | ||
| use crate::config::{Config, DefaultConfig}; | ||
| extern crate std; |
chiro-hiro
reviewed
Feb 14, 2025
zkmemory/src/config.rs
Outdated
| @@ -122,13 +125,19 @@ where | |||
| self.register.low() + (T::from(index) * self.word_size), | |||
| ) | |||
| } | |||
|
|
|||
| /// Get the buffer size in bytes | |||
| pub fn buffer_size_in_bytes(&self) -> T { | |||
There was a problem hiding this comment.
Don't modify program to test
chiro-hiro
reviewed
Feb 14, 2025
zkmemory/src/machine.rs
Outdated
| @@ -1,4 +1,5 @@ | |||
| extern crate alloc; | |||
| extern crate std; | |||
chiro-hiro
reviewed
Feb 14, 2025
zkmemory/src/machine.rs
Outdated
| @@ -927,6 +936,8 @@ mod tests { | |||
| for instruction in program { | |||
| sm.exec(&instruction); | |||
| } | |||
| assert_eq!(sm.get_memory_address().0, B256::from(35840)); | |||
There was a problem hiding this comment.
Are there any better way to compare?
chiro-hiro
reviewed
Feb 14, 2025
zkmemory/src/config.rs
Outdated
| @@ -77,11 +78,12 @@ where | |||
| /// Create a new config for given arguments | |||
| pub fn new(word_size: T, args: ConfigArgs<T>) -> Self { | |||
galin-chung-nguyen
force-pushed
the
feature/update_zkmemory_code_coverage
branch
from
d487bb3 to
8ede785
Compare
chiro-hiro
reviewed
Feb 17, 2025
zkmemory/Cargo.toml
Outdated
| @@ -32,3 +32,7 @@ nova-snark = { workspace = true } | |||
| bellpepper-core = { workspace = true } | |||
| poseidon = { path = "../poseidon" } | |||
| arecibo = { workspace = true } | |||
|
|
|||
| [features] | |||
| default = ["no_std"] | |||
chiro-hiro
approved these changes
Feb 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.