-
Notifications
You must be signed in to change notification settings - Fork 978
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a way to merge identity credentials. #2727
Comments
Hello contributors! I am marking this issue as stale as it has not received any engagement from the community or maintainers for a year. That does not imply that the issue has no merit! If you feel strongly about this issue
Throughout its lifetime, Ory has received over 10.000 issues and PRs. To sustain that growth, we need to prioritize and focus on issues that are important to the community. A good indication of importance, and thus priority, is activity on a topic. Unfortunately, burnout has become a topic of concern amongst open-source projects. It can lead to severe personal and health issues as well as opening catastrophic attack vectors. The motivation for this automation is to help prioritize issues in the backlog and not ignore, reject, or belittle anyone. If this issue was marked as stale erroneously you can exempt it by adding the Thank you for your understanding and to anyone who participated in the conversation! And as written above, please do participate in the conversation if this topic is important to you! Thank you 🙏✌️ |
Not cool GitHub actions 😛 |
When user tries to login with OIDC for the first time but has already registered before with email/password a credentials identifier conflict may be detected by Kratos. In this case user needs to login with email/password first and then link OIDC credentials on a settings screen. This PR simplifies UX and allows user to link OIDC credentials to existing account right in the login flow, without switching to settings flow. Closes ory#2727 Closes ory#3222
Preflight checklist
Describe your problem
Kratos does not allow automatic account linking when doing social sign-in. This is great for security reasons.
So, for instance, when an account for [email protected] exists in Kratos, and I connect through Google SSO, a new identity with [email protected] will be created if this Google account has never been used.
In our case, we want to allow our users to prove that they own the existing account by typing their password.
If they can prove this, we want to merge both identities together. More precisely, we want the Google SSO credentials to be linked to the existing identity - so that next time the user connects, they are connected with the existing identity.
Describe your ideal solution
One possible solution would be to provide an admin API endpoint in Kratos, that allows merging two identites.
We could identify the current identity through the Kratos cookie, and the target identity by passing their UUID in the URL.
The end result would be that the current identity has been deleted, and the credentials associated to it are now linked to the target identity.
This will allow having one transaction to encapsulate the logic.
The problem with the workaround is that it is subject to race conditions, if the target identity is updated at the same time by two or more requests I believe.
Workarounds or alternatives
The workaround we plan to use for now is:
Version
0.10.1
Additional Context
Discussed in the Ory Slack with Thomas => https://ory-community.slack.com/archives/C012RJ2MQ1H/p1662728891106129
The text was updated successfully, but these errors were encountered: