Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pip: don't catch .whl files #119

Closed
baruchiro opened this issue Jun 18, 2023 · 5 comments · Fixed by #142
Closed

Pip: don't catch .whl files #119

baruchiro opened this issue Jun 18, 2023 · 5 comments · Fixed by #142
Assignees
@OshriAsulin
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@baruchiro
Copy link
Collaborator

Originally posted by @baruchiro in #117 (comment)

Here, the command is:

pip install scipy-0.16.1-cp27-none-win_amd64.whl

We shouldn't consider this .whl as a package.

Please fix it.
Also, in the real-examples.yaml file, add a comment to the link https://stackoverflow.com/questions/26575587 that includes .whl file.
@baruchiro baruchiro added bug Something isn't working good first issue Good for newcomers labels Jun 18, 2023
@baruchiro baruchiro mentioned this issue Jun 18, 2023
Merged
@baruchiro baruchiro added good first issue Good for newcomers and removed good first issue Good for newcomers labels Jun 25, 2023
@OshriAsulin
Copy link
Contributor

I'm on it

@github-actions
Copy link

github-actions bot commented Jul 4, 2023

Hey! This task was taken over a few days ago, but nothing has happened since then. Maybe the current contributor can comment on this?

@baruchiro baruchiro mentioned this issue Jul 9, 2023
Closed
@baruchiro
Copy link
Collaborator Author

PR #131 was opened

@github-actions
Copy link

Hey! This task was taken over a few days ago, but nothing has happened since then. Maybe the current contributor can comment on this?

@github-actions
Copy link

Due to a long period of inactivity, this task was unassigned automatically.

@OshriAsulin OshriAsulin mentioned this issue Jul 28, 2023
Closed
@baruchiro baruchiro mentioned this issue Jul 28, 2023
Merged
github-merge-queue bot pushed a commit that referenced this issue Jul 30, 2023
@OshriAsulin @baruchiro
fix: ignore pip install .whl file (#142)
bda5fc7 
Continue of #140 
Close #119 

I added a change for ignore commands that end with `.whl`,
and I also added an example to real-examples.yaml

---------

Co-authored-by: Baruch Odem <[email protected]>
Co-authored-by: Baruch Odem (Rothkoff) <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@OshriAsulin OshriAsulin

Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
2 participants
@baruchiro @OshriAsulin