fix: url change without window load on npm #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- encoded the package name to ensure the link will open properly
…g the search bar - created a new event: EVENT_URL_CHANGE to notify content script on url change
- moved event handler of URL_CHANGED to `content-events.js` - added a new subscription method for url change in `content.js`
…tener. - changed page locator in test. - used a MutationObserver to insert `overlay-package-report` after the repository element is rendered (there are cases that the repository selector cannot be found since it's not yet rendered).
…erlay into fix-npm-search-update merge
- added utility function that waits for element to be rendered - rewrote test
- added utility function that waits for element to be rendered - rewrote test
Added a discord notification workflow. The file added was used for testing purposes, and if anyone else would want to test it. It may also be used to split up the notifying workflow from the other build and publish workflow, and I guess more platform notifications will be added overtime, but it is up to you. The notification content is:  **when creating the Discord webhook you can choose the name of the bot --------- Co-authored-by: Baruch Odem (Rothkoff) <[email protected]>
…erlay into fix-npm-search-update
organize imports - changed "chrome" to "browser" in background-events.js - added "tabs" permission to firefox manifest - moved event handler of URL_CHANGED to `content-events.js` - added a new subscription method for url change in `content.js` - added a test for issue os-scar#107 - moved EVENT_URL_CHANGED's event handler to the already existing listener. - changed page locator in test. - used a MutationObserver to insert `overlay-package-report` after the repository element is rendered (there are cases that the repository selector cannot be found since it's not yet rendered). - fixed test lint e2e too - removed "highlight" and fixed test - removed `tabs` permission from manifest - added utility function that waits for element to be rendered - rewrote test ci: add discord notification (os-scar#108) Added a discord notification workflow. The file added was used for testing purposes, and if anyone else would want to test it. It may also be used to split up the notifying workflow from the other build and publish workflow, and I guess more platform notifications will be added overtime, but it is up to you. The notification content is:  **when creating the Discord webhook you can choose the name of the bot --------- Co-authored-by: Baruch Odem (Rothkoff) <[email protected]> fix real examples lint e2e too - removed "highlight" and fixed test ci: add discord notification (os-scar#108) Added a discord notification workflow. The file added was used for testing purposes, and if anyone else would want to test it. It may also be used to split up the notifying workflow from the other build and publish workflow, and I guess more platform notifications will be added overtime, but it is up to you. The notification content is:  **when creating the Discord webhook you can choose the name of the bot --------- Co-authored-by: Baruch Odem (Rothkoff) <[email protected]> fix real examples - fixed typo
…erlay into fix-npm-search-update
baruchiro
reviewed
Jun 15, 2023
baruchiro
reviewed
Jun 15, 2023
baruchiro
changed the title
- trigger EVENT_URL_CHANGED only for specified domains
…erlay into fix-npm-search-update
baruchiro
reviewed
Jun 19, 2023
baruchiro
approved these changes
Jun 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EVENT_URL_CHANGEDthat notifies content script on URL changewaitForElementthat fires an action after a specified element is createdclose #107