Remove more calls to gap_to_julia #4634
Merged
+6
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgoettgens
added
the
release notes: not needed
fingolfin
reviewed
Feb 24, 2025
| @@ -240,7 +240,7 @@ end | |||
| ## GAP straight line program | |||
| function straight_line_program(slp::GapObj) | |||
| @req GAP.Globals.IsStraightLineProgram(slp) "slp must be a straight line program in GAP" | |||
| lines = GAP.gap_to_julia(GAP.Globals.LinesOfStraightLineProgram(slp); recursive = true) | |||
| lines = Vector{Any}(GAP.Globals.LinesOfStraightLineProgram(slp)) | |||
There was a problem hiding this comment.
Does this work? It might avoid a conversion when constructing the SLP.GAPSLProgram
Suggested change
| lines = Vector{Any}(GAP.Globals.LinesOfStraightLineProgram(slp)) | |
| lines = Vector{GAPStraightLine}(GAP.Globals.LinesOfStraightLineProgram(slp)) |
There was a problem hiding this comment.
nope, I tried that. But the conversion code is not capable of deciding which of the union elem types to convert each element of the vector to
fingolfin
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More progress towards #4625