Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

highway-almost-junction: avoid warnings on the intersecting node in P-shaped ways #2436

Merged
merged 1 commit into from
Feb 3, 2025

Conversation

Famlam
Copy link
Collaborator

@Famlam Famlam commented Jan 26, 2025

Currently analyser osmosis-highway-almost-junction also gives warnings about ways close to the intersecting node of P-shaped ways. This is usually incorrect.
image

Examples:

This PR disables the warning for the intersecting node.

Note: I didn't use ST_IsSimple, since this also caused a lot of false negatives for the other end node. Example

Also adds test cases

@frodrigo frodrigo merged commit bcd4706 into dev Feb 3, 2025
6 checks passed
@Famlam Famlam deleted the famlam-almost-junction-P branch February 3, 2025 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants