Nearby plases tmp #21980
Open
Nearby plases tmp #21980
+583
−154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chumva
reviewed
Feb 27, 2025
| val app = requireActivity().application as OsmandApplication | ||
| app.locationProvider.addLocationListener(this) | ||
| app.locationProvider.addCompassListener(this) | ||
| mapActivity?.dashboard?.setDashboardVisibility(true, DashboardType.EXPLORE_NEARBY_PLACES) |
There was a problem hiding this comment.
Do we really need to attach this fragment to dashboard?
Chumva
reviewed
Mar 3, 2025
| @@ -4,7 +4,7 @@ | |||
| xmlns:tools="http://schemas.android.com/tools" | |||
| android:layout_width="match_parent" | |||
| android:layout_height="match_parent" | |||
| android:background="?attr/activity_background_color" | |||
| android:background="@null" | |||
Chumva
reviewed
Mar 3, 2025
| @@ -68,7 +68,7 @@ public static List<OsmandApiFeatureData> getExploreImageList(KQuadRect mapRect, | |||
| } catch (UnsupportedEncodingException e) { | |||
| throw new RuntimeException(e); | |||
| } | |||
| LOG.debug("Download images " + url.toString()); | |||
| LOG.debug("Download images " + url + " {" + Thread.currentThread().getName() + "}"); | |||
There was a problem hiding this comment.
We should have thread name in PlatformUtil, is it necessary?
Chumva
reviewed
Mar 3, 2025
Comment on lines
+186
to
+197
| override fun updateLocation(location: Location?) { | ||
| this.location = location | ||
| verticalNearbyAdapter.updateLocation(location) | ||
| } | ||
|
|
||
| override fun updateCompassValue(value: Float) { | ||
| val now = System.currentTimeMillis() | ||
| if (now - lastCompassUpdate > COMPASS_UPDATE_PERIOD) { | ||
| lastCompassUpdate = now | ||
| updateLocation(location) | ||
| } | ||
| } |
There was a problem hiding this comment.
It is better to add checks for changes to reduce unnecessary list updates, example
Chumva
reviewed
Mar 3, 2025
|
|
||
| import org.apache.commons.logging.Log; | ||
|
|
||
| public class ExplorePlacesMenuBuilder extends MenuBuilder { |
There was a problem hiding this comment.
Do we need to show info from amenity here? or only from image data?
If needed, we could acquire amenity & show it`s info via AmenityUIHelper or similar to TransportStopMenuBuilder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.