Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What are "types" #1

Closed
bhousel opened this issue Mar 12, 2018 · 10 comments
Closed

What are "types" #1

bhousel opened this issue Mar 12, 2018 · 10 comments
Labels
question Further information is requested

Comments

@bhousel
Copy link
Member

bhousel commented Mar 12, 2018

Each resource has a "type" property..

{
    "type": "Feature",
    "properties": {
        "id": "OSM-US-Slack",
        "type": "slack",
        "country_code": "US",
        "name": "OpenStreetMap US Slack",
        "description": "Sign up at {url}",
        "url": "https://osmus-slack.herokuapp.com/"
    },
    "geometry": { 
        ...
    }

I left this a free-text property. But we might want to have a list of acceptable types.

@bhousel bhousel added the question Further information is requested label Mar 13, 2018
@bhousel
Copy link
Member Author

bhousel commented Mar 27, 2018

Followup on this, and this is related to how I will show these things in iD.

What if we say the "type" must correspond to one of the icons in the FontAwesome brands icon set? It seems to cover pretty much every kind of community I can think of.
https://fontawesome.com/icons?d=gallery&s=brands

@althio
Copy link

althio commented Mar 27, 2018 via email

@bhousel
Copy link
Member Author

bhousel commented Mar 28, 2018

Which icons would fit for forums and mailing lists?

Good point @althio ... Maybe we should just define a list of accepted types to avoid any confusion. We can easily expand the list later.

As for the icons, there are about 1000 free (CC BY 4.0) icons to pick from (the brands are a subset): https://fontawesome.com/icons?d=gallery&m=free

@bhousel
Copy link
Member Author

bhousel commented Mar 30, 2018

The list of allowable types is:

            "enum": [
                "discourse",
                "facebook",
                "forum",
                "group",
                "irc",
                "mailinglist",
                "meetup",
                "reddit",
                "slack",
                "telegram",
                "twitter"
            ]

Let me know if we're missing anything

@bhousel bhousel mentioned this issue Mar 30, 2018
bhousel pushed a commit that referenced this issue Apr 17, 2018
* adding Myanmar
* adding myanmar geojson
bhousel pushed a commit that referenced this issue Apr 18, 2018
Initial commit malaysia.geojson
bhousel pushed a commit that referenced this issue Apr 18, 2018
bhousel pushed a commit that referenced this issue Aug 2, 2018
bhousel pushed a commit that referenced this issue Sep 24, 2019
pull in upstream changes
@joostschouppe
Copy link
Contributor

The list of types has grown quite a bit. The map-filter @jbelien made (at https://community.osm.be/) makes this very visible. How about these two:

"osm" - a local OpenStreetMap page
"group" - A site for a local group with a url (such as a local OSM chapter page)

When I look at what's behind those two, they are basically the same. Everything under there could as well be "website". The only two exceptions, are "meetup groups organizing on the wiki" classified as a "group". I would propose changing those to "wiki", reclassify all others to "website".

I would also propose to add a new thing: lc-website. This would be for websites for organisations that are an officially recognized Local Chapter.

@bhousel
Copy link
Member Author

bhousel commented Oct 22, 2019

"osm" - a local OpenStreetMap page
"group" - A site for a local group with a url (such as a local OSM chapter page)

When I look at what's behind those two, they are basically the same. Everything under there could as well be "website". The only two exceptions, are "meetup groups organizing on the wiki" classified as a "group". I would propose changing those to "wiki", reclassify all others to "website".

Good points.. I still think of "types" as mostly "what icon to pick".

We should definitely change the description for group to not suggest that it is a local OSM chapter page. I think of "groups" more things like Maptime, or Mappa Merica, or Map Kibera - things where it would be misleading and weird to show an OSM logo next to them.

I'm ok with adding a new type for officially recognized local chapter pages. We could have osm-lc and osm to differentiate between official and unofficial local OSM groups.

@bhousel
Copy link
Member Author

bhousel commented Oct 22, 2019

@joostschouppe I did a few things!

  • I updated the contributing guidelines to improve the descriptions of the types, and show icons too. It looks nice!
  • I added a special osm-lc type and icon for official local chapters. The icon is like the OSM icon, but it has a star ⭐️
  • I updated the groups and local chapters in this index, and added whatever other official local chapters I could find here

@jbelien
Copy link
Contributor

jbelien commented Oct 22, 2019

Awesome!
Thanks a lot @bhousel ! I'll integrate this in https://community.osm.be/ in the next few days 🎉

@simonpoole
Copy link
Contributor

@bhousel the actual list of local chapters is here https://wiki.osmfoundation.org/wiki/Local_Chapters

@bhousel
Copy link
Member Author

bhousel commented Oct 22, 2019

the actual list of local chapters is here https://wiki.osmfoundation.org/wiki/Local_Chapters

ok, I just checked and thankfully it is the same list.
(Belgium, France, Germany, Iceland, Ireland, Italy, Switzerland, United Kingdom)

bhousel pushed a commit that referenced this issue Oct 12, 2020
bhousel pushed a commit that referenced this issue Apr 29, 2021
add two changes to same patch-1
bhousel pushed a commit that referenced this issue Jun 18, 2022
Create osm-taiwan-website.json
mahdi1234 pushed a commit to mahdi1234/osm-community-index that referenced this issue Nov 16, 2022
bhousel pushed a commit that referenced this issue Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

5 participants