Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pip: Fix getting the binary and source artifacts #5531

Merged
merged 1 commit into from
Jul 8, 2022
Merged

Conversation

mnonnenmacher
Copy link
Member

The PyPI JSON API was changed to only include the URLs for the current
version on the version specific JSON pages 1.

The PyPI JSON API was changed to only include the URLs for the current
version on the version specific JSON pages [1].

[1]: pypi/warehouse#11775

Signed-off-by: Martin Nonnenmacher <[email protected]>
@mnonnenmacher mnonnenmacher requested a review from a team as a code owner July 8, 2022 09:19
@mnonnenmacher mnonnenmacher enabled auto-merge (rebase) July 8, 2022 09:22
@codecov
Copy link

codecov bot commented Jul 8, 2022

Codecov Report

Merging #5531 (4e9fa7f) into main (c37961b) will decrease coverage by 0.72%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##               main    #5531      +/-   ##
============================================
- Coverage     72.00%   71.28%   -0.73%     
  Complexity     2102     2102              
============================================
  Files           268      268              
  Lines         14384    14528     +144     
  Branches       2223     2287      +64     
============================================
- Hits          10357    10356       -1     
- Misses         2942     3087     +145     
  Partials       1085     1085              
Flag Coverage Δ
funTest-non-analyzer 47.19% <ø> (-0.02%) ⬇️
test 32.65% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
analyzer/src/main/kotlin/managers/Pip.kt 50.00% <0.00%> (-21.43%) ⬇️
downloader/src/main/kotlin/vcs/Subversion.kt 71.32% <0.00%> (-0.74%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c37961b...4e9fa7f. Read the comment docs.

@mnonnenmacher mnonnenmacher merged commit 08df6b1 into main Jul 8, 2022
@mnonnenmacher mnonnenmacher deleted the pip-fix-urls branch July 8, 2022 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants