Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add input for specifying --file-mode #1509

Merged
merged 2 commits into from
Feb 18, 2025

Conversation

spencerschrock
Copy link
Member

@spencerschrock spencerschrock commented Feb 12, 2025

Introduced upstream in ossf/scorecard#4474

Also updates Scorecard to v5.1.1 for the data race fix.

Copy link

codecov bot commented Feb 13, 2025

Codecov Report

Attention: Patch coverage is 16.66667% with 5 lines in your changes missing coverage. Please review.

Project coverage is 32.47%. Comparing base (e48dbb7) to head (8d9ed48).
Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
internal/scorecard/scorecard.go 0.00% 5 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1509      +/-   ##
==========================================
- Coverage   32.55%   32.47%   -0.09%     
==========================================
  Files          13       13              
  Lines         771      776       +5     
==========================================
+ Hits          251      252       +1     
- Misses        495      499       +4     
  Partials       25       25              
Files with missing lines Coverage Δ
options/env.go 100.00% <ø> (ø)
options/options.go 84.61% <100.00%> (+0.10%) ⬆️
internal/scorecard/scorecard.go 0.00% <0.00%> (ø)

@spencerschrock spencerschrock force-pushed the file-mode branch 3 times, most recently from c0451ec to b4b9ae1 Compare February 17, 2025 20:04
@spencerschrock spencerschrock marked this pull request as ready for review February 17, 2025 20:09
fixes a data race in git file mode

Signed-off-by: Spencer Schrock <[email protected]>
@spencerschrock spencerschrock requested review from a team, justaugustus and raghavkaul and removed request for a team February 18, 2025 15:10
Copy link

@raghavkaul raghavkaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@spencerschrock spencerschrock merged commit 6a62a1c into ossf:main Feb 18, 2025
9 checks passed
@spencerschrock spencerschrock deleted the file-mode branch February 18, 2025 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants