Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerfile Build Using Golang Entrypoint #158

Merged
merged 3 commits into from
Mar 31, 2022
Merged

Conversation

rohankh532
Copy link
Contributor

@rohankh532 rohankh532 commented Mar 30, 2022

Changed the Dockerfile to use entrypoint.go instead of the shell script.

todo: add e2e tests

@codecov
Copy link

codecov bot commented Mar 30, 2022

Codecov Report

Merging #158 (793f025) into main (c8ed527) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #158   +/-   ##
=======================================
  Coverage   74.80%   74.80%           
=======================================
  Files           2        2           
  Lines         127      127           
=======================================
  Hits           95       95           
  Misses         25       25           
  Partials        7        7           
Impacted Files Coverage Δ
options/options.go 74.40% <ø> (ø)

@azeemshaikh38
Copy link
Contributor

@naveensrinivasan could you help with setting up e2e test for this? Basically, just like we have e2e tests today pointing to @main, can have a separate workflow in the test repos pointing to @golang-staging branch. That way, it'll be easy to figure out any breakages or differences between the 2 versions.

@naveensrinivasan naveensrinivasan mentioned this pull request Mar 30, 2022
@naveensrinivasan
Copy link
Member

@naveensrinivasan could you help with setting up e2e test for this? Basically, just like we have e2e tests today pointing to @main, can have a separate workflow in the test repos pointing to @golang-staging branch. That way, it'll be easy to figure out any breakages or differences between the 2 versions.

Sounds good. I can do that early next week.

@azeemshaikh38 azeemshaikh38 merged commit 0693f11 into main Mar 31, 2022
@azeemshaikh38 azeemshaikh38 deleted the golang-staging branch March 31, 2022 01:45
@azeemshaikh38
Copy link
Contributor

@naveensrinivasan could you help with setting up e2e test for this? Basically, just like we have e2e tests today pointing to @main, can have a separate workflow in the test repos pointing to @golang-staging branch. That way, it'll be easy to figure out any breakages or differences between the 2 versions.

Sounds good. I can do that early next week.

Thanks Naveen!

@rohankh532 rohankh532 restored the golang-staging branch April 5, 2022 23:53
justaugustus pushed a commit to justaugustus/scorecard that referenced this pull request May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants