Default Branch Checking Bugfix

[rohankh532]

PR to fix #169

[naveensrinivasan]

Looks good. @azeemshaikh38 👀

[naveensrinivasan]

Shouldn't this target golang-staging branch?

[codecov]

Codecov Report

Merging #171 (23f5937) into main (c8f6027) will increase coverage by 3.86%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #171      +/-   ##
==========================================
+ Coverage   58.45%   62.31%   +3.86%     
==========================================
  Files           3        3              
  Lines         207      207              
==========================================
+ Hits          121      129       +8     
+ Misses         75       69       -6     
+ Partials       11        9       -2     

Impacted Files	Coverage Δ
options/options.go	80.80% <100.00%> (+6.39%)	⬆️

[rohankh532]

Shouldn't this target golang-staging branch?

Oops, fixed.

[azeemshaikh38]

Shouldn't this target golang-staging branch?

Oops, fixed.

This should not be golang-staging, merging this to main is the right thing to do. Copying my reply to Naveen over slack here:

we want to merge these changes to main and after that to golang-staging . Basically, the only diff between main and golang-staging should be that the Dockerfile uses Golang instead of Bash. Everything else should be equivalent

[rohankh532]

Shouldn't this target golang-staging branch?

Oops, fixed.

This should not be golang-staging, merging this to main is the right thing to do. Copying my reply to Naveen over slack here:

we want to merge these changes to main and after that to golang-staging . Basically, the only diff between main and golang-staging should be that the Dockerfile uses Golang instead of Bash. Everything else should be equivalent

Got it, changed back to main.

[azeemshaikh38]

LGTM overall. Revert the changes on Dockerfile and ensure that the unit tests are passing.

[azeemshaikh38]

Thanks!