Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/do not skip root #25

Merged
merged 2 commits into from
May 24, 2020
Merged

Refactor/do not skip root #25

merged 2 commits into from
May 24, 2020

Conversation

otiai10
Copy link
Owner

@otiai10 otiai10 commented May 24, 2020

Similar to @Antonboom 's original idea, except

  • Change name of copyDispatcher to switchboard
  • Do not use os.FileInfo
  • Add some context in test cases

Thanks to @Antonboom

@codecov-commenter
Copy link

Codecov Report

Merging #25 into master will increase coverage by 1.92%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #25      +/-   ##
==========================================
+ Coverage   83.33%   85.26%   +1.92%     
==========================================
  Files           2        2              
  Lines          96       95       -1     
==========================================
+ Hits           80       81       +1     
+ Misses          8        7       -1     
+ Partials        8        7       -1     
Impacted Files Coverage Δ
copy.go 83.90% <100.00%> (+2.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26515b4...d54013a. Read the comment docs.

@otiai10 otiai10 merged commit c5f0361 into master May 24, 2020
@otiai10 otiai10 deleted the refactor/do-not-skip-root branch May 24, 2020 03:31
@Antonboom
Copy link
Contributor

Antonboom commented May 24, 2020

Thank u!

@otiai10, could you make a new tag? :)

@otiai10
Copy link
Owner Author

otiai10 commented May 24, 2020

v1.2.0 tagged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants