feat(bun/test): Allow functions as first arg to describe blocks
#17218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n. Updated types for describe. Implemented a test
|
nice, i think you should also make a test that runs |
Great suggestion - just added additional testing against the name |
DonIsaac
changed the title
describe blocks
DonIsaac
reviewed
Feb 21, 2025
| }); | ||
|
|
||
| test("both blocks should have run", () => { | ||
| expect(functionBlockRan).toBeTrue(); |
There was a problem hiding this comment.
use jest.fn to create a mock, then use expect(fn).toHaveBeenCalled()
| @@ -1725,7 +1725,7 @@ inline fn createScope( | |||
| var function = if (args.len > 1) args[1] else .zero; | |||
| var options = if (args.len > 2) args[2] else .zero; | |||
|
|
|||
| if (description.isEmptyOrUndefinedOrNull() or !description.isString()) { | |||
| if (description.isEmptyOrUndefinedOrNull() or (description.isFunction() and description.getName(globalThis).isEmpty())) { | |||
There was a problem hiding this comment.
What happens if
describe(MyClass, function testMyClass() {
// ...
});
There was a problem hiding this comment.
Also interested in how far Jest goes with this too
| test("describe block shows function name correctly in test output", async () => { | ||
| const test_dir = tmpdirSync(); | ||
| try { | ||
| await writeFile( |
There was a problem hiding this comment.
You'll find tempDirWithFiles useful here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Allows user to pass a function as the first argument to
describe.fixes #17100Before these changes if you pass a function you:
How did you verify your code works?
I wrote a passing test at
test/js/bun/test/describe.test.ts