Skip to content
This repository has been archived by the owner on Feb 20, 2019. It is now read-only.

FIx typo in log conditions example #4237

Merged
merged 2 commits into from
Jul 4, 2018
Merged

FIx typo in log conditions example #4237

merged 2 commits into from
Jul 4, 2018

Conversation

tomneedham
Copy link
Contributor

No description provided.

@phil-davis
Copy link
Contributor

Note that this can be log.condition or log.conditions - the code in lib/private/Log.php supports both. That happened in owncloud/core#27443

But it seems good to update documentation to consistently use log.conditions

@mmattel
Copy link
Contributor

mmattel commented Jul 4, 2018

Just double checked, @phil-davis is right, both parameter names can be used.
Agreeing to have that consistently named to log.conditions
👍

mmattel
mmattel previously approved these changes Jul 4, 2018
Copy link
Contributor

@mmattel mmattel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@tomneedham
Copy link
Contributor Author

Then this is an incorrect example by me, needs another set of brackets because conditions is an array of arrays.

@tomneedham
Copy link
Contributor Author

Updated

@settermjd settermjd merged commit f800a9b into master Jul 4, 2018
@settermjd settermjd deleted the tomneedham-patch-1 branch July 4, 2018 10:49
@settermjd
Copy link
Contributor

Thanks for spotting and addressing this, @phil-davis

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants