Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate email #569

Closed
wants to merge 2 commits into from
Closed

Validate email #569

wants to merge 2 commits into from

Conversation

PVince81
Copy link
Contributor

@PVince81 PVince81 commented Apr 13, 2017 •
edited
Loading

To be backported

@DeepDiver1975 FYI only the last commit

@PVince81 PVince81 added this to the 10.0 milestone Apr 13, 2017
@PVince81
Copy link
Contributor Author

PVince81 commented Apr 13, 2017 •
edited
Loading

  • TODO: also add to $processedUsers when email address is empty to properly discard the entries

@PVince81 PVince81 mentioned this pull request Apr 13, 2017
Closed
@PVince81 PVince81 modified the milestones: 10.0.1, 10.0 Apr 26, 2017
PVince81 added 2 commits April 26, 2017 11:27
@PVince81
Validate email before sending, exception handling
0dc370e 
Skip and discard entries of users with invalid email address instead of
retrying over and over again.

Also discard already processed entries even in case of error.
@PVince81
Also add empty email users as processed
966db2e
@PVince81
Copy link
Contributor Author

rebased

@PVince81 PVince81 modified the milestones: 10.0.2, 10.0.1 May 19, 2017
@PVince81
Copy link
Contributor Author 

1) OCA\Activity\Tests\BackgroundJob\EmailNotificationTest::testRunStep

Expectation failed for method name is equal to <string:sendEmailToUser> when invoked 1 time(s).

Method was expected to be called 1 times, actually called 0 times.

/home/travis/build/owncloud/core/apps/activity/vendor/phpunit/phpunit/src/TextUI/Command.php:188

/home/travis/build/owncloud/core/apps/activity/vendor/phpunit/phpunit/src/TextUI/Command.php:118

@PVince81 PVince81 mentioned this pull request Jun 21, 2017
Merged
@PVince81 PVince81 modified the milestones: triage, 10.0.2 Jun 29, 2017
@PVince81
Copy link
Contributor Author

PVince81 commented Jul 4, 2017

needs rethinking to fit in with #574

@PVince81
Copy link
Contributor Author

PVince81 commented Jul 5, 2017

@tomneedham does your other PR also cover invalid email addresses ? I see that we both added a catch block for exceptions. My PR might be obsolete then.

@tomneedham
Copy link
Contributor

Yes it will catch the exception and log it, and continue for other users.

@tomneedham
Copy link
Contributor

No pretty error message though :/

@PVince81
Copy link
Contributor Author

closing as obsolete and I don't have time for this anyway

@PVince81 PVince81 closed this Jul 10, 2017
@PVince81 PVince81 deleted the validate-email branch July 10, 2017 11:19
@DeepDiver1975 DeepDiver1975 removed this from the triage milestone Sep 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
2 - Developing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PVince81 @tomneedham @DeepDiver1975