-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to bigint #584
Migrate to bigint #584
Conversation
@VicDeo are you working on this? Please assign or let me know blockers ... |
@felixboehm in fact it is already done. it needs owncloud/core#28364 to pass the tests on postgresql |
So we need to be very carefull with merging this - if this requires core changes we need to increment the apps min depecndency to 10.0.3 - if we backport owncloud/core#28364 to 10.0.3 |
Can we release activity app now, and another version containing this fix with 10.0.3? |
yes |
I don't think this requires core changes. We don't have any foreign keys or anything... @VicDeo can you confirm ? |
@PVince81 this migration will fail on postgresql without a Doctrine patch from owncloud/core#28364 |
Rebased to test on top of the current master |
min oc version has to be 10.0.3 |
@DeepDiver1975 done |
@DeepDiver1975 dependencies are resolved: owncloud/core#28364 is merged into master/stable10. |
@VicDeo I suggest for core 10.0.3 beta to be out before merging. If we merge this then the activity app will not work at all with the core repo due to version mismatch. |
10.0.3 beta has been built (pending announcement) Merge? |
@DeepDiver1975 @VicDeo needs review / decision. I think we can already merge this. People checking out stable10 from git will get the correct version so the activity app from git will work. Once we release to app store, only people with 10.0.3 will see this release. So at no point will there be breakage. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
no backport needed, activity is released to the market from master |
Ref owncloud/core#26901