Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to bigint #584

Merged
merged 3 commits into from
Aug 16, 2017
Merged

Migrate to bigint #584

merged 3 commits into from
Aug 16, 2017

Conversation

VicDeo
Copy link
Member

@VicDeo VicDeo commented Jul 24, 2017

Ref owncloud/core#26901

@VicDeo VicDeo added this to the development milestone Jul 24, 2017
@felixboehm
Copy link
Contributor

@VicDeo are you working on this? Please assign or let me know blockers ...

@VicDeo
Copy link
Member Author

VicDeo commented Jul 25, 2017

@felixboehm in fact it is already done. it needs owncloud/core#28364 to pass the tests on postgresql

@DeepDiver1975
Copy link
Member

So we need to be very carefull with merging this - if this requires core changes we need to increment the apps min depecndency to 10.0.3 - if we backport owncloud/core#28364 to 10.0.3

@DeepDiver1975 DeepDiver1975 self-requested a review July 31, 2017 07:55
@DeepDiver1975 DeepDiver1975 self-assigned this Jul 31, 2017
@felixboehm
Copy link
Contributor

Can we release activity app now, and another version containing this fix with 10.0.3?

@DeepDiver1975
Copy link
Member

Can we release activity app now, and another version containing this fix with 10.0.3?

yes

@PVince81
Copy link
Contributor

PVince81 commented Aug 3, 2017

if this requires core changes

I don't think this requires core changes. We don't have any foreign keys or anything...

@VicDeo can you confirm ?

@VicDeo
Copy link
Member Author

VicDeo commented Aug 3, 2017

@PVince81 this migration will fail on postgresql without a Doctrine patch from owncloud/core#28364

@VicDeo
Copy link
Member Author

VicDeo commented Aug 3, 2017

Rebased to test on top of the current master

@DeepDiver1975
Copy link
Member

min oc version has to be 10.0.3

@VicDeo
Copy link
Member Author

VicDeo commented Aug 3, 2017

@DeepDiver1975 done

@VicDeo
Copy link
Member Author

VicDeo commented Aug 10, 2017

@DeepDiver1975 dependencies are resolved: owncloud/core#28364 is merged into master/stable10.
Is anything else needed from my side to get this in?

@VicDeo VicDeo self-assigned this Aug 10, 2017
@PVince81
Copy link
Contributor

@VicDeo I suggest for core 10.0.3 beta to be out before merging. If we merge this then the activity app will not work at all with the core repo due to version mismatch.

@PVince81
Copy link
Contributor

10.0.3 beta has been built (pending announcement)

Merge?

@PVince81
Copy link
Contributor

@DeepDiver1975 @VicDeo needs review / decision.

I think we can already merge this. People checking out stable10 from git will get the correct version so the activity app from git will work. Once we release to app store, only people with 10.0.3 will see this release. So at no point will there be breakage.

Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81 PVince81 merged commit 6caa6e1 into master Aug 16, 2017
@PVince81 PVince81 deleted the bigint branch August 16, 2017 11:15
@PVince81
Copy link
Contributor

no backport needed, activity is released to the market from master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants