Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable10] Dont try to delete items when no users in context #605

Closed
wants to merge 2 commits into from
Closed

[stable10] Dont try to delete items when no users in context #605

wants to merge 2 commits into from

Conversation

tomneedham
Copy link
Contributor

Backport of #604 to stable10

@tomneedham tomneedham added this to the development milestone Dec 18, 2017
@tomneedham tomneedham self-assigned this Dec 18, 2017
@tomneedham tomneedham requested a review from PVince81 December 18, 2017 12:03
PVince81
PVince81 approved these changes Dec 18, 2017
View reviewed changes
Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@codecov-io
Copy link

codecov-io commented Dec 18, 2017 •
edited
Loading

Codecov Report

Merging #605 into master will decrease coverage by 0.04%.
The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #605      +/-   ##
============================================
- Coverage     86.37%   86.33%   -0.05%     
- Complexity      464      465       +1     
============================================
  Files            36       36              
  Lines          1732     1734       +2     
============================================
+ Hits           1496     1497       +1     
- Misses          236      237       +1
Impacted Files Coverage Δ Complexity Δ
lib/MailQueueHandler.php 99.05% <66.66%> (-0.95%) 18 <2> (+1)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b0db1e...7d41cee. Read the comment docs.

@PVince81
Copy link
Contributor

codecov not happy, need unit test update

@tomneedham
Copy link
Contributor Author

This does not make sense / have any effect until #574 is backported

@tomneedham
Copy link
Contributor Author

And requires the new tests from the original PR

@tomneedham tomneedham changed the base branch from master to stable10 March 6, 2018 10:04
@tomneedham
Copy link
Contributor Author

@ownclouders rebase

@tomneedham tomneedham closed this Mar 9, 2018
@tomneedham
Copy link
Contributor Author

closing as I made new fixes in the upstream branch

@tomneedham tomneedham deleted the stable10-fix-delete branch March 9, 2018 12:36
@patrickjahns patrickjahns removed this from the development milestone Jun 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PVince81 PVince81 PVince81 approved these changes

Assignees

@tomneedham tomneedham

Labels
3 - To review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tomneedham @codecov-io @PVince81 @patrickjahns