Change getAvatarFolder to accept user object

This is to make sure we don't get into user id casing issues.

lib/private/AvatarManager.php

@@ -33,6 +33,7 @@
 use OCP\IUserManager;
 use OCP\Files\IRootFolder;
 use OCP\IL10N;
+use OCP\IUser;
 
 /**
  * This class implements methods to access Avatar functionality
@@ -86,7 +87,7 @@ public function getAvatar($userId) {
 
 		$userId = $user->getUID();
 
-		$avatarsFolder = $this->getAvatarFolder($userId);
+		$avatarsFolder = $this->getAvatarFolder($user);
 		return new Avatar($avatarsFolder, $this->l, $user, $this->logger);
 	}
 
@@ -106,14 +107,14 @@ private function buildAvatarPath($userId) {
 	/**
 	 * Returns the avatar folder for the given user
 	 *
-	 * @param $userId user id
+	 * @param IUser $user user
 	 * @return Folder|\OCP\Files\Node
 	 *
 	 * @internal
 	 */
-	public function getAvatarFolder($userId) {
+	public function getAvatarFolder(IUser $user) {
 		$avatarsFolder = $this->getFolder($this->rootFolder, 'avatars');
-		$parts = $this->buildAvatarPath($userId);
+		$parts = $this->buildAvatarPath($user->getUID());
 		foreach ($parts as $part) {
 			$avatarsFolder = $this->getFolder($avatarsFolder, $part);
 		}

lib/private/Repair/MoveAvatarOutsideHome.php

@@ -110,7 +110,7 @@ private function moveAvatars(IOutput $out, IUser $user) {
 			$oldAvatarUserFolder = $this->rootFolder->get('/' . $userId);
 			$oldAvatar = new Avatar($oldAvatarUserFolder, $this->l, $user, $this->logger);
 			if ($oldAvatar->exists()) {
-				$newAvatarsUserFolder = $this->avatarManager->getAvatarFolder($userId);
+				$newAvatarsUserFolder = $this->avatarManager->getAvatarFolder($user);
 
 				// get original file
 				$oldAvatarFile = $oldAvatar->getFile(-1);

tests/lib/AvatarManagerTest.php

@@ -120,7 +120,7 @@ public function testGetAvatarValidUserDifferentCasing() {
 		$folder = $this->createMock(Folder::class);
 		$this->avatarManager->expects($this->once())
 			->method('getAvatarFolder')
-			->with('valid-user')
+			->with($user)
 			->willReturn($folder);
 
 		$avatar = $this->avatarManager->getAvatar('vaLid-USER');