Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[User management] International email addresses aren't valid #13586

Closed
SergioBertolinSG opened this issue Jan 22, 2015 · 38 comments · Fixed by #33207
Closed

[User management] International email addresses aren't valid #13586

SergioBertolinSG opened this issue Jan 22, 2015 · 38 comments · Fixed by #33207

Comments

@SergioBertolinSG
Copy link
Contributor

SergioBertolinSG commented Jan 22, 2015

Steps to reproduce

Using an admin user:

Activate send email to new users checkbox

  1. Create a new user with international email address.

Expected behaviour

International email addresses are allowed.

Actual behaviour

International email addresses (with Ñ,Ö,Ç..) are invalid.

Server configuration

Operating system:
Ubuntu 14.04 LTS

Web server:
Apache

Database:
MySQL

PHP version:
5.5.9

ownCloud version: (see ownCloud admin page)
{"installed":true,"maintenance":false,"version":"8.0.0.1","versionstring":"8.0 alpha 1","edition":""}

Updated from an older ownCloud or fresh install:
fresh

List of activated apps:
none

The content of config/config.php:

Insert your config.php content here
(Without the database password and passwordsalt)

Are you using external storage, if yes which one: local/smb/sftp/...
no

Are you using encryption: no

Client configuration

Browser:
Chrome, Firefox

@DeepDiver1975
Copy link
Member

@SergioBertolinSG is the php module intl installed and enabled?

@SergioBertolinSG
Copy link
Contributor Author

Yes it is installed and enabled, version 1.1.0

@DeepDiver1975 DeepDiver1975 added this to the 8.1-next milestone Jan 22, 2015
@DeepDiver1975
Copy link
Member

which email address did you try?

@SergioBertolinSG
Copy link
Contributor Author

bjö[email protected] españ[email protected] that kind of addresses

@SergioBertolinSG SergioBertolinSG mentioned this issue Jan 22, 2015
27 tasks
@DeepDiver1975
Copy link
Member

hehe - even github fails to parse these emails properly 🙊

@rullzer
Copy link
Contributor

rullzer commented Apr 13, 2015

So it is not that hard to fix owncloud accepting the e-mail.
It is basically in the lib/private/mail/*.php files. And we do not convert idn stuff in for the user part of the e-mail address.
So like I said fixing is not that hard. But I do not know if swiftmailer accepts it then. Also this is something that should really be fixed in the swiftmailer :P

@DeepDiver1975
Copy link
Member

So like I said fixing is not that hard. But I do not know if swiftmailer accepts it then. Also this is something that should really be fixed in the swiftmailer :P

swiftmailer is used from 8.1 on - this issue was filed as we did use phpmailer.

bjö[email protected] españ[email protected] that kind of addresses

I really question if these are valid email addresses - I did a quick research back in January and idn is specified for the domain - but for the user part: ????

@SergioBertolinSG
Copy link
Contributor Author

RFC 6530, RFC 6531, RFC 6532 and RFC 6533 talks about this.
Gmail is supporting it http://googleblog.blogspot.com.es/2014/08/a-first-step-toward-more-global-email.html
But perhaps It's not worth implementing it.

@DeepDiver1975
Copy link
Member

Thanks for your input @SergioBertolinSG - we shall reevaluate this in oc8.1 - because we switched over to swiftmailer

@karlitschek
Copy link
Contributor

@SergioBertolinSG Can you retest with 8.1 alpha3 ?

@SergioBertolinSG
Copy link
Contributor Author

Still happening in 8.1 alpha3.

@DeepDiver1975
Copy link
Member

@nickvergessen wana have a look? THX

@nickvergessen
Copy link
Contributor

Not a lot we can do I guess. Swift says the email is invalid:
https://github.com/owncloud/3rdparty/blob/08b820614ae99477d7c9319630f400d22b20e2fd/swiftmailer/swiftmailer/lib/classes/Swift/Validate.php#L37-L40

or does swift have some kind of config for this? @LukasReschke

@DeepDiver1975
Copy link
Member

thx @nickvergessen - let's file an issue upstream - can you please take care? THX

@nickvergessen
Copy link
Contributor

@DeepDiver1975
Copy link
Member

THX @nickvergessen

@DeepDiver1975
Copy link
Member

let's move this to 8.2

@DeepDiver1975 DeepDiver1975 modified the milestones: 8.2-next, 8.1-current May 5, 2015
@nickvergessen
Copy link
Contributor

It has been fixed upstream in SwiftMailer 6.0 which is backwards incompatible and uses a thirdparty to validate the emails.

@PVince81
Copy link
Contributor

@nickvergessen @DeepDiver1975 how to move forward with this ?

@ghost ghost added sev2-high and removed sev3-medium labels Sep 21, 2015
@DeepDiver1975
Copy link
Member

swiftmailer 6.0 is no yet released - we have to postpone this until it has been release -> 9.0

@DeepDiver1975 DeepDiver1975 added this to the 9.0-next milestone Sep 24, 2015
@PVince81
Copy link
Contributor

we could update the lib on master as we intend to only support PHP >= 7.0 (or 7.1?) in the upcoming major OC version 10.1

@PVince81
Copy link
Contributor

@DeepDiver1975 will dependabot find this or do we need to update master's composer.json file to have 7.0 as minimum ? ^

@PVince81
Copy link
Contributor

should we then disable email validation or something ?

@PVince81
Copy link
Contributor

swift mailer was updated for master here #29943, so with a bit of luck this will work now.

will assign to QA for verifying

@DeepDiver1975
Copy link
Member

will assign to QA for verifying

a simple unit test shall help to verify .....

@DeepDiver1975
Copy link
Member

PR open - unit test shows that this is working now -> close as soon as merged

phil-davis added a commit that referenced this issue Mar 13, 2019
…ion-intl

[stable10] Test email verification with international email address - fixes #13586
@lock lock bot locked as resolved and limited conversation to collaborators Oct 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.