Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Versions not moved when moving file into shared folder as recipient #15867

Closed
PVince81 opened this issue Apr 24, 2015 · 3 comments
Closed

Versions not moved when moving file into shared folder as recipient #15867

PVince81 opened this issue Apr 24, 2015 · 3 comments

Comments

@PVince81
Copy link
Contributor

Steps

  1. Create a user "user1"
  2. Create a folder "folder"
  3. Share "folder" with "user1"
  4. Login as "user1"
  5. Create a file "test.txt" in the root
  6. Edit "test.txt" several times to create versions
  7. Move "test.txt" into "folder"

Expected result

Versions copied properly from "user1/files_versions" to "root/files_versions/folder"

Actual result

Versions stay in "user1/files_versions"

{"reqId":"vUiI+zniWleqqCzZcre2","remoteAddr":"127.0.0.1","app":"core","message":"unable to rename, destination directory is not writable : files_versions\/folder","level":3,"time":"2015-04-24T13:27:34+00:00","method":"POST","url":"\/owncloud\/index.php\/apps\/files\/ajax\/move.php"}
{"reqId":"vUiI+zniWleqqCzZcre2","remoteAddr":"127.0.0.1","app":"core","message":"unable to rename, destination directory is not writable : files_versions\/folder","level":3,"time":"2015-04-24T13:27:34+00:00","method":"POST","url":"\/owncloud\/index.php\/apps\/files\/ajax\/move.php"}
{"reqId":"vUiI+zniWleqqCzZcre2","remoteAddr":"127.0.0.1","app":"core","message":"unable to rename, destination directory is not writable : files_versions\/folder","level":3,"time":"2015-04-24T13:27:34+00:00","method":"POST","url":"\/owncloud\/index.php\/apps\/files\/ajax\/move.php"}
{"reqId":"vUiI+zniWleqqCzZcre2","remoteAddr":"127.0.0.1","app":"core","message":"unable to rename, destination directory is not writable : files_versions\/folder","level":3,"time":"2015-04-24T13:27:34+00:00","method":"POST","url":"\/owncloud\/index.php\/apps\/files\/ajax\/move.php"}

Versions

ownCloud git master (33d197d)

@schiesbn

@PVince81
Copy link
Contributor Author

At the time where the versions are moved, the wrong absolute path is used. It uses "user1" in both even though the target should be relative to "root".

@PVince81
Copy link
Contributor Author

Okay, it looks like this is a very old undiscovered bug. Saw it happening on stable7 too.

@PVince81
Copy link
Contributor Author

Fixed through #15881

@lock lock bot locked as resolved and limited conversation to collaborators Aug 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants