Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix version rename with files and folders #15881

Merged
merged 1 commit into from
May 11, 2015
Merged

Conversation

PVince81
Copy link
Contributor

Please review @schiesbn @nickvergessen @icewind1991

- fix moving folder into another folder
- fix moving file or folder into shared folder as recipient
@PVince81 PVince81 added this to the 8.1-current milestone Apr 27, 2015
@PVince81
Copy link
Contributor Author

@karlitschek we might want to backport this: moving a folder loses the versions of all contained files when moved into another folder, happens on stable7 and stable8.

@scrutinizer-notifier
Copy link

The inspection completed: 2 new issues, 3 updated code elements

@ghost
Copy link

ghost commented Apr 27, 2015

Refer to this link for build results (access rights to CI server needed):
https://ci.owncloud.org//job/pull-request-analyser-ng-simple/11834/
🚀 Test PASSed.🚀
chuck

@karlitschek
Copy link
Contributor

yes. please backport after 8.0.3 👍

@schiessle
Copy link
Contributor

looks good 👍

@rullzer
Copy link
Contributor

rullzer commented Apr 29, 2015

Looking good! 👍
Tested both scenarios and working!

I'm having problems with versions via webdav but that is also on master. So this is unrelated.

@PVince81
Copy link
Contributor Author

@rullzer versions via WebDAV ? There is no such thing in ownCloud. Still curious to hear how you did it 😄

PVince81 pushed a commit that referenced this pull request May 11, 2015
Fix version rename with files and folders
@PVince81 PVince81 merged commit 20d2d8d into master May 11, 2015
@PVince81 PVince81 deleted the share-moveversionsproperly branch May 11, 2015 16:24
@PVince81
Copy link
Contributor Author

I'll take care of the backport to stable8.
@karlitschek you didn't specify whether you also agreed with a stable7 backport as it is losing versions there too.

@PVince81
Copy link
Contributor Author

stable8: #16369

mmattel pushed a commit to mmattel/core that referenced this pull request May 22, 2015
…perly

Fix version rename with files and folders
@lock lock bot locked as resolved and limited conversation to collaborators Aug 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants