Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable10] Repair subshares earlier to avoid errors #34462

Merged
merged 1 commit into from
Feb 12, 2019
Merged

[stable10] Repair subshares earlier to avoid errors #34462

merged 1 commit into from
Feb 12, 2019

Conversation

PVince81
Copy link
Contributor

Backport of #34439 to stable10

Repair subshares earlier to avoid errors
d4b9998 
On some environments, some of the other repair steps would setup the FS
and fail with errors due to duplicate shares.
@PVince81 PVince81 added this to the development milestone Feb 12, 2019
@PVince81 PVince81 self-assigned this Feb 12, 2019
@PVince81 PVince81 requested a review from sharidas February 12, 2019 07:27
@PVince81 PVince81 mentioned this pull request Feb 12, 2019
Merged
11 tasks
sharidas
sharidas approved these changes Feb 12, 2019
View reviewed changes
Copy link
Contributor

@sharidas sharidas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@codecov
Copy link

codecov bot commented Feb 12, 2019

Codecov Report

Merging #34462 into stable10 will increase coverage by 0.02%.
The diff coverage is 0%.

Impacted file tree graph

@@              Coverage Diff               @@
##             stable10   #34462      +/-   ##
==============================================
+ Coverage       63.55%   63.57%   +0.02%     
- Complexity      19143    19146       +3     
==============================================
  Files            1265     1265              
  Lines           75307    75314       +7     
  Branches         1291     1291              
==============================================
+ Hits            47858    47884      +26     
+ Misses          27069    27050      -19     
  Partials          380      380
Flag Coverage Δ Complexity Δ
#javascript 53.32% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 64.67% <0%> (+0.03%) 19146 <0> (+3) ⬆️
Impacted Files Coverage Δ Complexity Δ
lib/private/Repair.php 25.88% <0%> (ø) 21 <0> (ø) ⬇️
lib/private/Setup.php 27.6% <0%> (+11.24%) 52% <0%> (+3%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e061087...d4b9998. Read the comment docs.

2 similar comments
@codecov
Copy link

codecov bot commented Feb 12, 2019

Codecov Report

Merging #34462 into stable10 will increase coverage by 0.02%.
The diff coverage is 0%.

Impacted file tree graph

@@              Coverage Diff               @@
##             stable10   #34462      +/-   ##
==============================================
+ Coverage       63.55%   63.57%   +0.02%     
- Complexity      19143    19146       +3     
==============================================
  Files            1265     1265              
  Lines           75307    75314       +7     
  Branches         1291     1291              
==============================================
+ Hits            47858    47884      +26     
+ Misses          27069    27050      -19     
  Partials          380      380
Flag Coverage Δ Complexity Δ
#javascript 53.32% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 64.67% <0%> (+0.03%) 19146 <0> (+3) ⬆️
Impacted Files Coverage Δ Complexity Δ
lib/private/Repair.php 25.88% <0%> (ø) 21 <0> (ø) ⬇️
lib/private/Setup.php 27.6% <0%> (+11.24%) 52% <0%> (+3%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e061087...d4b9998. Read the comment docs.

@codecov
Copy link

codecov bot commented Feb 12, 2019 •
edited
Loading

Codecov Report

Merging #34462 into stable10 will increase coverage by 0.02%.
The diff coverage is 0%.

Impacted file tree graph

@@              Coverage Diff               @@
##             stable10   #34462      +/-   ##
==============================================
+ Coverage       63.55%   63.57%   +0.02%     
- Complexity      19143    19146       +3     
==============================================
  Files            1265     1265              
  Lines           75307    75314       +7     
  Branches         1291     1291              
==============================================
+ Hits            47858    47884      +26     
+ Misses          27069    27050      -19     
  Partials          380      380
Flag Coverage Δ Complexity Δ
#javascript 53.32% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 64.67% <0%> (+0.03%) 19146 <0> (+3) ⬆️
Impacted Files Coverage Δ Complexity Δ
lib/private/Repair.php 25.88% <0%> (ø) 21 <0> (ø) ⬇️
lib/private/Setup.php 27.6% <0%> (+11.24%) 52% <0%> (+3%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e061087...d4b9998. Read the comment docs.

@PVince81 PVince81 merged commit 3f1c2c3 into stable10 Feb 12, 2019
@PVince81 PVince81 deleted the stable10-repair-subshares-earlier branch February 12, 2019 13:31
@PVince81 PVince81 modified the milestones: development, QA Apr 12, 2019
This was referenced Apr 15, 2019
Closed
Closed
@lock lock bot locked as resolved and limited conversation to collaborators Apr 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sharidas sharidas sharidas approved these changes

Assignees

@PVince81 PVince81

Labels
3 - To Review
Projects
None yet
Milestone
10.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@PVince81 @sharidas