Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repair subshares earlier to avoid errors #34439

Merged
merged 1 commit into from
Feb 12, 2019
Merged

Conversation

PVince81
Copy link
Contributor

Description

On some environments, some of the other repair steps would setup the FS
and fail with errors due to duplicate shares.

Related Issue

Motivation and Context

How Has This Been Tested?

Tested on user's test environment where the failure occurred and confirmed working.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • Backport (if applicable set "backport-request" label and remove when the backport was done)

On some environments, some of the other repair steps would setup the FS
and fail with errors due to duplicate shares.
@codecov
Copy link

codecov bot commented Feb 11, 2019

Codecov Report

Merging #34439 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #34439   +/-   ##
=========================================
  Coverage     64.77%   64.77%           
  Complexity    18372    18372           
=========================================
  Files          1199     1199           
  Lines         69566    69566           
  Branches       1282     1282           
=========================================
  Hits          45063    45063           
  Misses        24130    24130           
  Partials        373      373
Flag Coverage Δ Complexity Δ
#javascript 53.08% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.13% <0%> (ø) 18372 <0> (ø) ⬇️
Impacted Files Coverage Δ Complexity Δ
lib/private/Repair.php 25.88% <0%> (ø) 21 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c354962...5a9bd7b. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Feb 11, 2019

Codecov Report

Merging #34439 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #34439   +/-   ##
=========================================
  Coverage     64.77%   64.77%           
  Complexity    18372    18372           
=========================================
  Files          1199     1199           
  Lines         69566    69566           
  Branches       1282     1282           
=========================================
  Hits          45063    45063           
  Misses        24130    24130           
  Partials        373      373
Flag Coverage Δ Complexity Δ
#javascript 53.08% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.13% <0%> (ø) 18372 <0> (ø) ⬇️
Impacted Files Coverage Δ Complexity Δ
lib/private/Repair.php 25.88% <0%> (ø) 21 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c354962...5a9bd7b. Read the comment docs.

Copy link
Contributor

@sharidas sharidas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@PVince81 PVince81 merged commit 000d4ce into master Feb 12, 2019
@delete-merged-branch delete-merged-branch bot deleted the repair-subshares-earlier branch February 12, 2019 07:26
@PVince81
Copy link
Contributor Author

stable10: #34462

@lock lock bot locked as resolved and limited conversation to collaborators Feb 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants