-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Repair subshares earlier to avoid errors #34439
Conversation
On some environments, some of the other repair steps would setup the FS and fail with errors due to duplicate shares.
Codecov Report
@@ Coverage Diff @@
## master #34439 +/- ##
=========================================
Coverage 64.77% 64.77%
Complexity 18372 18372
=========================================
Files 1199 1199
Lines 69566 69566
Branches 1282 1282
=========================================
Hits 45063 45063
Misses 24130 24130
Partials 373 373
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #34439 +/- ##
=========================================
Coverage 64.77% 64.77%
Complexity 18372 18372
=========================================
Files 1199 1199
Lines 69566 69566
Branches 1282 1282
=========================================
Hits 45063 45063
Misses 24130 24130
Partials 373 373
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
stable10: #34462 |
Description
On some environments, some of the other repair steps would setup the FS
and fail with errors due to duplicate shares.
Related Issue
Motivation and Context
How Has This Been Tested?
Tested on user's test environment where the failure occurred and confirmed working.
Screenshots (if appropriate):
Types of changes
Checklist:
Open tasks: