Expose backend type via REST API #12711
Conversation
|
Yes - I know that exposing the class name directly is not really the best approach to this but I consider it a sensible solution for now. Open for other suggestions though. |
LukasReschke
force-pushed
the
add-backend-to-rest-index
branch
from
dde0cd1 to
cf516da
Compare
|
@PVince81 Easy one - up for a review as well? :-) |
|
@DeepDiver1975 Please update lint on the CI server. It can't handle the PHP 5.4 short array syntax. |
|
Error from CI: Code: ->will($this->returnValue(['foo' => 'M. Foo', 'admin' => 'S. Admin', 'bar' => 'B. Ar'])); |
LukasReschke
force-pushed
the
add-backend-to-rest-index
branch
from
cf516da to
77e9717
Compare
| for (var i = 0; i < trs.length; i++) { | ||
| trs[i].removeClass('transparent'); | ||
| } | ||
| }, 0); | ||
| UserList.updating = false; |
There was a problem hiding this comment.
This line should then in the .always() callback. Otherwise it will show the loading state on error all the time.
There was a problem hiding this comment.
Indeed. Very good catch. - Adjusted with b09ee3b
This change will expose the user backend via the REST API which is a pre-requisite for #12620. For example: ````json [{"name":"9707A09E-CA9A-4ABE-A66A-3F632F16C409","displayname":"Document Conversion User Account","groups":[],"subadmin":[],"quota":"default","storageLocation":"\/Users\/lreschke\/Programming\/core\/data\/9707A09E-CA9A-4ABE-A66A-3F632F16C409","lastLogin":0,"backend":"OCA\\user_ldap\\USER_LDAP"},{"name":"ED86733E-745C-4E4D-90CB-278A9737DB3C","displayname":"Hacker","groups":[],"subadmin":[],"quota":"default","storageLocation":"\/Users\/lreschke\/Programming\/core\/data\/ED86733E-745C-4E4D-90CB-278A9737DB3C","lastLogin":0,"backend":"OCA\\user_ldap\\USER_LDAP"},{"name":"71CDF45B-E125-450D-983C-D9192F36EC88","displayname":"admin","groups":[],"subadmin":[],"quota":"default","storageLocation":"\/Users\/lreschke\/Programming\/core\/data\/71CDF45B-E125-450D-983C-D9192F36EC88","lastLogin":0,"backend":"OCA\\user_ldap\\USER_LDAP"},{"name":"admin","displayname":"admin","groups":["admin"],"subadmin":[],"quota":"default","storageLocation":"\/Users\/lreschke\/Programming\/core\/data\/admin","lastLogin":"1418057287","backend":"OC_User_Database"},{"name":"test","displayname":"test","groups":[],"subadmin":[],"quota":"default","storageLocation":"\/Users\/lreschke\/Programming\/core\/data\/test","lastLogin":0,"backend":"OC_User_Database"}] ```
LukasReschke
force-pushed
the
add-backend-to-rest-index
branch
from
b09ee3b to
4c13918
Compare
|
Switched back to PHP 5.3 array notation for the sake of being able to merge this on time… |
|
Isn't that the file |
No idea. Filed #12720 for that. |
|
Branch for CI: #12723 |
|
The inspection completed: 4 new issues, 5 updated code elements |
|
From #12723 (comment) 🚀 Test PASSed. 🚀 Who wants to make me happy and review this? :) |
This adds a "backend" type filter to the index REST route which is a pre-requisite for #12620 For example when calling `index.php/settings/users/users?offset=0&limit=10&gid=&pattern=&backend=OC_User_Database` only users within the backend `OC_User_Database` would be shown. (requires sending a CSRF token as well) Depends upon #12711
|
Mentioning @nickvergessen as he always likes to review stuff. |
|
👍 |
|
php looks good, didn't review js |
|
@nickvergessen It's nearly just intendation: https://github.com/owncloud/core/pull/12711/files?w=1#diff-3 Just have a look if the list is still loaded, then everything is fine. |
|
As discussed with Joas, merging. |
Expose backend type via REST API
This adds a "backend" type filter to the index REST route which is a pre-requisite for #12620 For example when calling `index.php/settings/users/users?offset=0&limit=10&gid=&pattern=&backend=OC_User_Database` only users within the backend `OC_User_Database` would be shown. (requires sending a CSRF token as well) Depends upon #12711
This change will expose the user backend via the REST API which is a pre-requisite for #12620.
For example:
[{ "name": "9707A09E-CA9A-4ABE-A66A-3F632F16C409", "displayname": "Document Conversion User Account", "groups": [], "subadmin": [], "quota": "default", "storageLocation": "\/Users\/lreschke\/Programming\/core\/data\/9707A09E-CA9A-4ABE-A66A-3F632F16C409", "lastLogin": 0, "backend": "OCA\\user_ldap\\USER_LDAP" }, { "name": "ED86733E-745C-4E4D-90CB-278A9737DB3C", "displayname": "Hacker", "groups": [], "subadmin": [], "quota": "default", "storageLocation": "\/Users\/lreschke\/Programming\/core\/data\/ED86733E-745C-4E4D-90CB-278A9737DB3C", "lastLogin": 0, "backend": "OCA\\user_ldap\\USER_LDAP" }, { "name": "71CDF45B-E125-450D-983C-D9192F36EC88", "displayname": "admin", "groups": [], "subadmin": [], "quota": "default", "storageLocation": "\/Users\/lreschke\/Programming\/core\/data\/71CDF45B-E125-450D-983C-D9192F36EC88", "lastLogin": 0, "backend": "OCA\\user_ldap\\USER_LDAP" }, { "name": "admin", "displayname": "admin", "groups": ["admin"], "subadmin": [], "quota": "default", "storageLocation": "\/Users\/lreschke\/Programming\/core\/data\/admin", "lastLogin": "1418057287", "backend": "OC_User_Database" }, { "name": "test", "displayname": "test", "groups": [], "subadmin": [], "quota": "default", "storageLocation": "\/Users\/lreschke\/Programming\/core\/data\/test", "lastLogin": 0, "backend": "OC_User_Database" }]@MorrisJobke Please review.