Fix cache update when doing a rename that overwrites the target #14575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jnfrmarks Can you verify? |
|
adding backport-request because of #14559 @icewind1991 please prepare PR against stable8 - THX |
|
Would it be possible to add an unit test? – I mean we should be able to detect if a SQL error happened – right? |
|
|
backport would be great |
icewind1991
force-pushed
the
cache-rename-overwrite
branch
from
3c02ba0 to
fc027bc
Compare
|
Added test |
|
Works, code makes sense 👍 |
|
Refer to this link for build results (access rights to CI server needed): |
|
Fixes the issue - tested 👍 |
MorrisJobke
added a commit
that referenced
this pull request
Feb 27, 2015
Fix cache update when doing a rename that overwrites the target
|
@icewind1991 Can you create the backport PR? Thanks |
|
The inspection completed: 4 new issues, 1 updated code elements |
|
stable8: #14584 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14559
@jnfrmarks can you verify that this fixes the problem for you?
cc @DeepDiver1975 @PVince81 @LukasReschke