Print error if logged couldn't log it in index.php #26075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@PVince81, thanks for your PR! By analyzing the annotation information on this pull request, we identified @DeepDiver1975, @butonic and @LukasReschke to be potential reviewers |
|
Okay, to reproduce the issue just set open_basedir and make /dev/urandom not accessible: #26076 |
| OC_Template::printExceptionErrorPage($ex); | ||
| } catch (\Exception $ex2) { | ||
| // with some env issues, it can happen that the logger couldn't log properly, | ||
| // so print out the exception directlry |
|
@PVince81 ok, just fix a typo and here is my 👍 |
In some rare env problem cases, the exception cannot be logged because the logger couldn't be initialized properly. In such cases, we now print the stack trace directly on the output.
PVince81
force-pushed
the
print-error-if-exception-failed
branch
from
5cafbf4 to
cd1abb4
Compare
Current coverage is 59.58%
|
|
Fixed typo and merging as index.php isn't covered anyway |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
@DeepDiver1975 @VicDeo @butonic @guruz