[debug] [stable9.1] Fix initMountPoints to set usersSetup earlier #26396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@PVince81, thanks for your PR! By analyzing the history of the files in this pull request, we identified @icewind1991, @nickvergessen and @MorrisJobke to be potential reviewers. |
This is needed because in some cases like LDAP, the user manager itself might trigger avatar updates which would internally also call initMountPoints with the same user. This could cause the same user to be setup twice, and in some sharing situations could cause recursive deduplication of shares by adding "(2)" every time.
PVince81
force-pushed
the
stable9.1-userssetup-check
branch
from
a7abe32 to
517277b
Compare
PVince81
changed the title
|
closing as this conflicts, but I want to keep the code as patch for the users of the original ticket to test on their 9.1.1 instance. Superseded by #26399 which solves the conflicts. |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is needed because in some cases like LDAP, the user manager itself
might trigger avatar updates which would internally also call
initMountPoints with the same user. This could cause the same user to
be setup twice, and in some sharing situations could cause recursive
deduplication of shares by adding "(2)" every time.
Related Issue
Fixes #25718
Motivation and Context
See description
How Has This Been Tested?
Very difficult to reproduce: #25718 (comment)
Tested with the provided DB dump with LDAP + avatars, in an env where the issue could be reproduced.
Screenshots (if appropriate):
Types of changes
Checklist:
Backports:
Potentially this issue could appear in previous versions as well, maybe in different forms, so I'd say let's backport to:
@jvillafanez @DeepDiver1975