Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mimetype detection for trashbin items #28091

Merged
merged 1 commit into from
Jun 12, 2017
Merged

Conversation

VicDeo
Copy link
Member

@VicDeo VicDeo commented Jun 6, 2017

Description

Related Issue

Fixes #27932

Motivation and Context

Any trashbin item has a mimetype "application/octet-stream"

How Has This Been Tested?

By deleting items with a preview / browsing into trashbin

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@VicDeo VicDeo added this to the 10.0.3 milestone Jun 6, 2017
@VicDeo VicDeo requested a review from davitol June 6, 2017 15:15
@davitol
Copy link
Contributor

davitol commented Jun 7, 2017

👍 Tested and WFM

@butonic butonic merged commit 48278db into master Jun 12, 2017
@butonic butonic deleted the fix-trashbin-mimetypes branch June 12, 2017 08:16
@VicDeo
Copy link
Member Author

VicDeo commented Jun 12, 2017

@PVince81 Backport to stable10?

@PVince81
Copy link
Contributor

@VicDeo sounds good

@VicDeo
Copy link
Member Author

VicDeo commented Jun 19, 2017

Stable10: #28158

@lock
Copy link

lock bot commented Aug 3, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Thumbnails are not shown in the trashbin section
4 participants