Use dav versions in files

apps/dav/lib/Connector/Sabre/FilesPlugin.php

@@ -31,6 +31,8 @@
 namespace OCA\DAV\Connector\Sabre;
 
 use OC\AppFramework\Http\Request;
+use OCA\DAV\Files\IProvidesAdditionalHeaders;
+use OCA\DAV\Meta\MetaFile;
 use OCP\Files\ForbiddenException;
 use Sabre\DAV\Exception\Forbidden;
 use Sabre\DAV\Exception\NotFound;
@@ -231,6 +233,9 @@ function httpGet(RequestInterface $request, ResponseInterface $response) {
 		// adds a 'Content-Disposition: attachment' header
 		if ($this->downloadAttachment) {
 			$filename = $node->getName();
+			if ($node instanceof IProvidesAdditionalHeaders) {
+				$filename = $node->getContentDispositionFileName();
+			}
 			if ($this->request->isUserAgent(
 				[
 					Request::USER_AGENT_IE,
@@ -255,6 +260,13 @@ function httpGet(RequestInterface $request, ResponseInterface $response) {
 			// cause memory problems in the nginx process.
 			$response->addHeader('X-Accel-Buffering', 'no');
 		}
+
+		if ($node instanceof IProvidesAdditionalHeaders) {
+			$headers = $node->getHeaders();
+			if (is_array($headers)) {
+				$response->addHeaders($headers);
+			}
+		}
 	}
 
 	/**

apps/dav/lib/Connector/Sabre/Node.php

@@ -384,6 +384,9 @@ public function changeLock($type) {
 		$this->fileView->changeLock($this->path, $type);
 	}
 
+	/**
+	 * @return \OCP\Files\FileInfo
+	 */
 	public function getFileInfo() {
 		return $this->info;
 	}

apps/dav/lib/Connector/Sabre/Server.php

@@ -24,6 +24,8 @@
 
 namespace OCA\DAV\Connector\Sabre;
 
+use OCA\DAV\DAV\CopyPlugin;
+
 /**
  * Class \OCA\DAV\Connector\Sabre\Server
  *
@@ -40,5 +42,6 @@ public function __construct($treeOrNode = null) {
 		parent::__construct($treeOrNode);
 		self::$exposeVersion = false;
 		$this->enablePropfindDepthInfinity = true;
+		$this->addPlugin(new CopyPlugin());
 	}
 }

apps/dav/lib/DAV/CopyPlugin.php

@@ -0,0 +1,103 @@
+<?php
+/**
+ * @author Thomas Müller <[email protected]>
+ *
+ * @copyright Copyright (c) 2017, ownCloud GmbH
+ * @license AGPL-3.0
+ *
+ * This code is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU Affero General Public License, version 3,
+ * as published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU Affero General Public License for more details.
+ *
+ * You should have received a copy of the GNU Affero General Public License, version 3,
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>
+ *
+ */
+
+
+namespace OCA\DAV\DAV;
+
+use OCA\DAV\Connector\Sabre\Exception\Forbidden;
+use OCA\DAV\Connector\Sabre\File;
+use OCA\DAV\Files\ICopySource;
+use OCP\Files\ForbiddenException;
+use Sabre\DAV\IFile;
+use Sabre\DAV\Server;
+use Sabre\DAV\ServerPlugin;
+use Sabre\HTTP\RequestInterface;
+use Sabre\HTTP\ResponseInterface;
+
+/**
+ * Class CopyPlugin - adds own implementation of the COPY method.
+ * This is necessary because we don't want the target to be deleted before the move.
+ *
+ * Deleting the target will kill the versions which is the wrong behavior.
+ *
+ * @package OCA\DAV\DAV
+ */
+class CopyPlugin extends ServerPlugin {
+
+	/** @var Server */
+	private $server;
+
+	/**
+	 * @param Server $server
+	 */
+	function initialize(Server $server) {
+		$this->server = $server;
+		$server->on('method:COPY',      [$this, 'httpCopy'], 90);
+	}
+
+	/**
+	 * WebDAV HTTP COPY method
+	 *
+	 * This method copies one uri to a different uri, and works much like the MOVE request
+	 * A lot of the actual request processing is done in getCopyMoveInfo
+	 *
+	 * @param RequestInterface $request
+	 * @param ResponseInterface $response
+	 * @return bool
+	 * @throws Forbidden
+	 */
+	function httpCopy(RequestInterface $request, ResponseInterface $response) {
+
+		try {
+
+			$path = $request->getPath();
+
+			$copyInfo = $this->server->getCopyAndMoveInfo($request);
+			$sourceNode = $this->server->tree->getNodeForPath($path);
+			$destinationNode = $copyInfo['destinationNode'];
+			if (!$copyInfo['destinationExists'] || !$destinationNode instanceof File || !$sourceNode instanceof IFile) {
+				return true;
+			}
+
+			if (!$this->server->emit('beforeBind', [$copyInfo['destination']])) return false;
+
+			$copySuccess = false;
+			if ($sourceNode instanceof ICopySource) {
+				$copySuccess = $sourceNode->copy($destinationNode->getFileInfo()->getPath());
+			}
+			if (!$copySuccess) {
+				$destinationNode->put($sourceNode->get());
+			}
+
+			$this->server->emit('afterBind', [$copyInfo['destination']]);
+
+			$response->setHeader('Content-Length', '0');
+			$response->setStatus(204);
+
+			// Sending back false will interrupt the event chain and tell the server
+			// we've handled this method.
+			return false;
+		} catch (ForbiddenException $ex) {
+			throw new Forbidden($ex->getMessage(), $ex->getRetry());
+		}
+	}
+
+}

apps/dav/lib/Files/ICopySource.php

@@ -0,0 +1,43 @@
+<?php
+/**
+ * @author Thomas Müller <[email protected]>
+ *
+ * @copyright Copyright (c) 2017, ownCloud GmbH
+ * @license AGPL-3.0
+ *
+ * This code is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU Affero General Public License, version 3,
+ * as published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU Affero General Public License for more details.
+ *
+ * You should have received a copy of the GNU Affero General Public License, version 3,
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>
+ *
+ */
+
+
+namespace OCA\DAV\Files;
+
+
+/**
+ * Interface ICopySource
+ * This interface allows special handling of copy operations based on the copy source.
+ * This gives the developer the freedom to implement a more efficient copy operation.
+ *
+ * @package OCA\DAV\Files
+ */
+interface ICopySource {
+
+	/**
+	 * Copies the source to the given destination.
+	 * If the operation was not successful false is returned.
+	 *
+	 * @param string $destinationPath
+	 * @return boolean
+	 */
+	public function copy($destinationPath);
+}

apps/dav/lib/Files/IProvidesAdditionalHeaders.php

@@ -0,0 +1,44 @@
+<?php
+/**
+ * @author Thomas Müller <[email protected]>
+ *
+ * @copyright Copyright (c) 2017, ownCloud GmbH
+ * @license AGPL-3.0
+ *
+ * This code is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU Affero General Public License, version 3,
+ * as published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU Affero General Public License for more details.
+ *
+ * You should have received a copy of the GNU Affero General Public License, version 3,
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>
+ *
+ */
+
+
+namespace OCA\DAV\Files;
+
+
+/**
+ * Interface IProvidesAdditionalHeaders
+ * This interface allows to add additional headers to the response
+ *
+ * @package OCA\DAV\Files
+ */
+interface IProvidesAdditionalHeaders {
+
+	/**
+	 * @return array
+	 */
+	public function getHeaders();
+
+	/**
+	 * @return string
+	 */
+	public function getContentDispositionFileName();
+
+}

apps/dav/lib/Meta/MetaFile.php

@@ -23,9 +23,18 @@
 namespace OCA\DAV\Meta;
 
 
+use OC\Files\Meta\MetaFileVersionNode;
+use OCA\DAV\Files\ICopySource;
+use OCA\DAV\Files\IProvidesAdditionalHeaders;
 use Sabre\DAV\File;
 
-class MetaFile extends File {
+/**
+ * Class MetaFile
+ * This is a Sabre based implementation of a file living in the /meta resource.
+ *
+ * @package OCA\DAV\Meta
+ */
+class MetaFile extends File implements ICopySource, IProvidesAdditionalHeaders {
 
 	/** @var \OCP\Files\File */
 	private $file;
@@ -74,7 +83,40 @@ public function getLastModified() {
 		return $this->file->getMTime();
 	}
 
+	/**
+	 * @inheritdoc
+	 */
 	public function getETag() {
 		return $this->file->getEtag();
 	}
+
+	/**
+	 * @inheritdoc
+	 */
+	public function copy($path) {
+		if ($this->file instanceof MetaFileVersionNode) {
+			return $this->file->copy($path);
+		}
+		return false;
+	}
+
+	/**
+	 * @return array
+	 */
+	public function getHeaders() {
+		if ($this->file instanceof \OCP\Files\IProvidesAdditionalHeaders) {
+			return $this->file->getHeaders();
+		}
+		return [];
+	}
+
+	/**
+	 * @return string
+	 */
+	public function getContentDispositionFileName() {
+		if ($this->file instanceof \OCP\Files\IProvidesAdditionalHeaders) {
+			return $this->file->getContentDispositionFileName();
+		}
+		return $this->getName();
+	}
 }

apps/dav/lib/Meta/MetaFolder.php

@@ -28,6 +28,12 @@
 use OCP\Files\Node;
 use Sabre\DAV\Collection;
 
+/**
+ * Class MetaFolder
+ * This is a Sabre based implementation of a folder living in the /meta resource.
+ *
+ * @package OCA\DAV\Meta
+ */
 class MetaFolder extends Collection {
 
 	/** @var Folder */
@@ -48,7 +54,7 @@ public function __construct(Folder $folder) {
 	function getChildren() {
 		$nodes = $this->folder->getDirectoryListing();
 		return array_map(function($node) {
-			return static::nodeFactory($node);
+			return $this->nodeFactory($node);
 		}, $nodes);
 	}
 
@@ -59,7 +65,7 @@ function getName() {
 		return $this->folder->getName();
 	}
 
-	public static function nodeFactory(Node $node) {
+	private function nodeFactory(Node $node) {
 		if ($node instanceof Folder) {
 			return new MetaFolder($node);
 		}

apps/dav/lib/Meta/RootCollection.php

@@ -23,10 +23,8 @@
 namespace OCA\DAV\Meta;
 
 
-use OCP\Files\File;
-use OCP\Files\Folder;
+use OC\Files\Meta\MetaFileIdNode;
 use OCP\Files\IRootFolder;
-use OCP\Files\Node;
 use OCP\Files\NotFoundException;
 use Sabre\DAV\Collection;
 use Sabre\DAV\Exception\MethodNotAllowed;
@@ -52,8 +50,11 @@ public function __construct(IRootFolder $rootFolder) {
 	public function getChild($name) {
 		try {
 			$child = $this->rootFolder->get("meta/$name");
-			return MetaFolder::nodeFactory($child);
-		} catch (NotFoundException $ex) {
+			if (!$child instanceof MetaFileIdNode) {
+				throw new NotFound();
+			}
+			return new MetaFolder($child);
+		} catch (NotFoundException $exception) {
 			throw new NotFound();
 		}
 	}