Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove originalCss reference in oc-dialogs #29465

Merged
merged 1 commit into from
Nov 6, 2017

Conversation

felixheidecke
Copy link
Contributor

@felixheidecke felixheidecke commented Nov 6, 2017

Description

Related Issue

Fixes: #29459

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@felixheidecke felixheidecke added 3 - To Review Type:Bug p1-urgent Critical issue, need to consider hotfix with just that issue regression labels Nov 6, 2017
@felixheidecke felixheidecke added this to the development milestone Nov 6, 2017
Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, works 👍

Thanks a lot!

@PVince81
Copy link
Contributor

PVince81 commented Nov 6, 2017

@felixheidecke please submit the backport PR for stable10.

I'm confident that CI should pass...

@codecov
Copy link

codecov bot commented Nov 6, 2017

Codecov Report

Merging #29465 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #29465   +/-   ##
=========================================
  Coverage     60.84%   60.84%           
  Complexity    17238    17238           
=========================================
  Files          1032     1032           
  Lines         57365    57365           
=========================================
  Hits          34904    34904           
  Misses        22461    22461

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33de611...c26bca6. Read the comment docs.

@PVince81 PVince81 merged commit 800f59f into master Nov 6, 2017
@PVince81 PVince81 deleted the 29459-fix-oc-dialog-closing branch November 6, 2017 21:38
@phil-davis
Copy link
Contributor

Backport stable10 #29467

@lock
Copy link

lock bot commented Aug 2, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
4 - To release p1-urgent Critical issue, need to consider hotfix with just that issue regression status/STALE Type:Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Conflict dialog does not close properly any more
4 participants