Add missing CorsController in settings's Application #29736
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since "settings" is not an application but the app framework thinks it
is, it tries to resolve the namespaces to OCA. However we used OC for
all the controllers, so we need to register these explicitly into the
settings Application container.
Related Issue
None raised. Found by @phil-davis during QA of 10.0.4 RC1.
Motivation and Context
How Has This Been Tested?
Go to settings page, "Security" section. Add a whitelist domain for CORS.
Before fix: full page internal server error with exception about CorsController missing.
After fix: domain can be added.
Screenshots (if appropriate):
Types of changes
Checklist: