Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing CorsController in settings's Application #29736

Merged
merged 1 commit into from
Dec 1, 2017
Merged

Conversation

PVince81
Copy link
Contributor

@PVince81 PVince81 commented Dec 1, 2017

Description

Since "settings" is not an application but the app framework thinks it
is, it tries to resolve the namespaces to OCA. However we used OC for
all the controllers, so we need to register these explicitly into the
settings Application container.

Related Issue

None raised. Found by @phil-davis during QA of 10.0.4 RC1.

Motivation and Context

How Has This Been Tested?

Go to settings page, "Security" section. Add a whitelist domain for CORS.

Before fix: full page internal server error with exception about CorsController missing.
After fix: domain can be added.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Since "settings" is not an application but the app framework thinks it
is, it tries to resolve the namespaces to OCA. However we used OC for
all the controllers, so we need to register these explicitly into the
settings Application container.
@PVince81 PVince81 added 3 - To Review p1-urgent Critical issue, need to consider hotfix with just that issue labels Dec 1, 2017
@PVince81 PVince81 added this to the QA milestone Dec 1, 2017
@PVince81 PVince81 mentioned this pull request Dec 1, 2017
87 tasks
@codecov
Copy link

codecov bot commented Dec 1, 2017

Codecov Report

Merging #29736 into master will decrease coverage by <.01%.
The diff coverage is 12.5%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #29736      +/-   ##
============================================
- Coverage     62.62%   62.61%   -0.01%     
  Complexity    17581    17581              
============================================
  Files          1037     1037              
  Lines         57906    57914       +8     
============================================
+ Hits          36262    36263       +1     
- Misses        21644    21651       +7
Impacted Files Coverage Δ Complexity Δ
settings/Application.php 50.98% <12.5%> (-2.13%) 2 <0> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e806a96...e2b98cd. Read the comment docs.

@PVince81
Copy link
Contributor Author

PVince81 commented Dec 1, 2017

stable10: #29741

@lock
Copy link

lock bot commented Aug 1, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
3 - To Review p1-urgent Critical issue, need to consider hotfix with just that issue status/STALE
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants