Bugfix/30078 #30113
Merged
Bugfix/30078 #30113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing collections - fixes #3078
PVince81
approved these changes
Jan 12, 2018
apps/dav/lib/Server.php
Outdated
| @@ -117,7 +125,7 @@ public function __construct(IRequest $request, $baseUri) { | |||
| // with performance and locking issues because it will query | |||
| // every parent node which might trigger an implicit rescan in the | |||
| // case of external storages with update detection | |||
| if (strpos($this->server->getRequestUri(), 'files/') !== 0) { | |||
| if (!$this->requestIsForSubtree('files')) { | |||
There was a problem hiding this comment.
I'd have gone with isRequestForSubtree as starting method name with is is some kind of convention.
Optional, up to you.
|
again mariadb timout - |
:damn:
DeepDiver1975
force-pushed
the
bugfix/30078
branch
from
397e74f to
74b2998
Compare
Codecov Report
@@ Coverage Diff @@
## master #30113 +/- ##
============================================
- Coverage 58.24% 58.22% -0.03%
- Complexity 18525 18528 +3
============================================
Files 1094 1094
Lines 63739 63749 +10
============================================
- Hits 37126 37118 -8
- Misses 26613 26631 +18
Continue to review full report at Codecov.
|
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Outside of the CardDAV collection we shall not change the file content.
In addition:
Related Issue
fixes #30078
How Has This Been Tested?
Types of changes
Checklist: