Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix overflowing public link title #30238

Merged
merged 1 commit into from
May 7, 2018

Conversation

felixheidecke
Copy link
Contributor

Description

Long public-link titles will be ellipsed if they are "too long" to prevent pushing interactive elements out of view (and reach).

Related Issue

https://central.owncloud.org/t/offentlicher-link-in-version-10-0-4-ist-nicht-kopierbar/11468

Motivation and Context

See above.

How Has This Been Tested?

Visual/functional test in latest FF and Chrome.
(My VM broke so pls test in IE)

Screenshots (if appropriate):

before-and-after

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@PVince81
Copy link
Contributor

PVince81 commented Feb 8, 2018

can we get this tested in IE11 ?

@felixheidecke
Copy link
Contributor Author

can we get this tested in IE11 ?

Wink @ChrisEdS ;-)

@felixheidecke felixheidecke force-pushed the fix-overflowing-public-link-title branch from 995c7cd to ad0a6bb Compare February 9, 2018 10:49
@codecov
Copy link

codecov bot commented Feb 9, 2018

Codecov Report

Merging #30238 into master will decrease coverage by 1.7%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #30238      +/-   ##
============================================
- Coverage     62.59%   60.88%   -1.71%     
- Complexity    18227    18572     +345     
============================================
  Files          1145     1093      -52     
  Lines         68414    61329    -7085     
  Branches       1234        0    -1234     
============================================
- Hits          42821    37339    -5482     
+ Misses        25232    23990    -1242     
+ Partials        361        0     -361
Flag Coverage Δ Complexity Δ
#javascript ? ?
#phpunit ? ?
Impacted Files Coverage Δ Complexity Δ
core/templates/layout.noscript.warning.php 0% <0%> (-100%) 0% <0%> (ø)
lib/private/Template/JSResourceLocator.php 0% <0%> (-100%) 13% <0%> (+1%)
lib/private/Template/CSSResourceLocator.php 0% <0%> (-100%) 10% <0%> (ø)
core/templates/layout.base.php 0% <0%> (-100%) 0% <0%> (ø)
lib/private/DB/PostgreSqlMigrator.php 0% <0%> (-100%) 6% <0%> (ø)
...ilder/ExpressionBuilder/PgSqlExpressionBuilder.php 0% <0%> (-88.89%) 3% <0%> (ø)
lib/private/DB/AdapterOCI8.php 0% <0%> (-86.67%) 4% <0%> (ø)
lib/private/DB/AdapterPgSql.php 0% <0%> (-85.72%) 2% <0%> (ø)
...Builder/ExpressionBuilder/OCIExpressionBuilder.php 0% <0%> (-85.19%) 18% <0%> (ø)
apps/files/lib/Command/Scan.php 0% <0%> (-80.92%) 47% <0%> (-25%)
... and 464 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e044095...c163238. Read the comment docs.

@felixheidecke felixheidecke force-pushed the fix-overflowing-public-link-title branch from ad0a6bb to 346079d Compare February 9, 2018 10:52
@phil-davis
Copy link
Contributor

More "random" UI test fails in drone. One of them was when trying to delete the last file in a folder, and in another run:

 GuzzleHttp\Exception\ServerException: Server error response [url] http://server/remote.php/webdav/lorem.txt [status code] 503 [reason phrase] Service Unavailable in /drone/src/lib/composer/guzzlehttp/guzzle/src/Exception/RequestException.php:89

I restarted drone again.

@PVince81
Copy link
Contributor

conflicts

@felixboehm felixboehm modified the milestones: development, planned Apr 10, 2018
@PVince81
Copy link
Contributor

@felixheidecke please solve the conflict so we can merge this

Beautify code according to coding style guidelines
@felixheidecke felixheidecke force-pushed the fix-overflowing-public-link-title branch from 346079d to c163238 Compare May 2, 2018 10:38
@DeepDiver1975 DeepDiver1975 merged commit 062340c into master May 7, 2018
@DeepDiver1975 DeepDiver1975 deleted the fix-overflowing-public-link-title branch May 7, 2018 08:59
@PVince81 PVince81 modified the milestones: development, QA Jun 13, 2018
@lock
Copy link

lock bot commented Jul 31, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants