Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When executing the data-fingerprint command a log entry is written to… #30251

Merged
merged 2 commits into from
Jan 25, 2018

Conversation

DeepDiver1975
Copy link
Member

@DeepDiver1975 DeepDiver1975 commented Jan 24, 2018

… allow analysis who executed the command and when

Description

Executing the data fingerprint command has some large impact on the system.
The command should be logged for later analysis who executed the command.

In addition it is worth a second user confirmation before applying the data-fingerprint.

Related Issue

refs #30154

Motivation and Context

Make owncloud a bit more robust

How Has This Been Tested?

  • manual
  • unit tests

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@DeepDiver1975 DeepDiver1975 added this to the development milestone Jan 24, 2018
@DeepDiver1975 DeepDiver1975 self-assigned this Jan 24, 2018
@codecov
Copy link

codecov bot commented Jan 25, 2018

Codecov Report

Merging #30251 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #30251      +/-   ##
============================================
+ Coverage     58.35%   58.37%   +0.01%     
- Complexity    18571    18574       +3     
============================================
  Files          1093     1093              
  Lines         63780    63796      +16     
============================================
+ Hits          37221    37238      +17     
+ Misses        26559    26558       -1
Impacted Files Coverage Δ Complexity Δ
drone/src/core/routes.php 65.51% <0%> (-4.18%) 0% <0%> (ø)
...e/src/core/Command/Maintenance/DataFingerprint.php 100% <0%> (ø) 4% <0%> (+1%) ⬆️
drone/src/lib/private/Server.php 82.55% <0%> (ø) 129% <0%> (ø) ⬇️
drone/src/apps/dav/lib/CalDAV/CalDavBackend.php 80.05% <0%> (+0.16%) 170% <0%> (+1%) ⬆️
drone/src/apps/dav/lib/CardDAV/CardDavBackend.php 82.97% <0%> (+0.2%) 79% <0%> (+1%) ⬆️
drone/src/apps/files_trashbin/lib/Expiration.php 98.27% <0%> (+1.72%) 29% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebbd08e...855f421. Read the comment docs.

Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81 PVince81 merged commit a46ca75 into master Jan 25, 2018
@PVince81 PVince81 deleted the add-logging-for-fingerprint-command branch January 25, 2018 15:22
@DeepDiver1975
Copy link
Member Author

backport - yes/no .....

@PVince81
Copy link
Contributor

if safe, yes...

@lock
Copy link

lock bot commented Aug 1, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants