-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix webUI display of group containing numeric username #30732
Conversation
Codecov Report
@@ Coverage Diff @@
## master #30732 +/- ##
=========================================
Coverage 62.24% 62.24%
- Complexity 18248 18249 +1
=========================================
Files 1091 1091
Lines 61665 61665
=========================================
Hits 38386 38386
Misses 23279 23279
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
please backport |
Backport stable10 #30811 |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Description
When looking up a user id allow the
uid
to be a number that "looks like a string" - allowing a number of any sort (which will always cast itself into a non-empty string later as required)I went looking for an API test for this - there does not seem to be anything directly for
settings/users/...
- but I noticed that there is no provisioning test to make sure that endpoint provides a list of users in a group, so added one here. That passes with string and numeric usernames.Related Issue
#30727
Motivation and Context
"random" issues with numeric<=>string mixups are annoying. Fix them.
How Has This Been Tested?
123
aaa
123
to groupaaa
aaa
in the groups left-side panel123
is displayedTypes of changes
Checklist: