Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix webUI display of group containing numeric username #30732

Merged
merged 2 commits into from
Mar 19, 2018
Merged

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Mar 8, 2018

Description

  1. When looking up a user id allow the uid to be a number that "looks like a string" - allowing a number of any sort (which will always cast itself into a non-empty string later as required)

  2. I went looking for an API test for this - there does not seem to be anything directly for settings/users/... - but I noticed that there is no provisioning test to make sure that endpoint provides a list of users in a group, so added one here. That passes with string and numeric usernames.

Related Issue

#30727

Motivation and Context

"random" issues with numeric<=>string mixups are annoying. Fix them.

How Has This Been Tested?

  1. In the webUI, login as admin and add user 123
  2. Add a group aaa
  3. Add user 123 to group aaa
  4. Click on group aaa in the groups left-side panel
  5. See that the group member 123 is displayed

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Mar 8, 2018

Codecov Report

Merging #30732 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #30732   +/-   ##
=========================================
  Coverage     62.24%   62.24%           
- Complexity    18248    18249    +1     
=========================================
  Files          1091     1091           
  Lines         61665    61665           
=========================================
  Hits          38386    38386           
  Misses        23279    23279
Impacted Files Coverage Δ Complexity Δ
lib/private/User/Manager.php 81.56% <100%> (ø) 53 <0> (+1) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f4f3c6...7c02113. Read the comment docs.

Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81 PVince81 merged commit 0db13ab into master Mar 19, 2018
@PVince81 PVince81 deleted the fix-issue-30727 branch March 19, 2018 10:00
@PVince81
Copy link
Contributor

please backport

@phil-davis
Copy link
Contributor Author

Backport stable10 #30811

@lock
Copy link

lock bot commented Jul 31, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants