Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix settings page where elements are inline when they shouldn't #30958

Merged
merged 3 commits into from
Apr 3, 2018
Merged

Fix settings page where elements are inline when they shouldn't #30958

merged 3 commits into from
Apr 3, 2018

Conversation

felixheidecke
Copy link
Contributor

@felixheidecke felixheidecke commented Mar 29, 2018 •
edited
Loading

Description

Fix shifting headlines in setting panel

Related Issue

#30914

How Has This Been Tested?

Visual tests in FF & Chrome (latest)

Screenshots (if appropriate):

Before:
screen shot 2018-03-26 at 13 23 43

After:
bildschirmfoto 2018-03-29 um 12 07 01

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@felixheidecke felixheidecke added Type:Bug 3 - To Review settings:admin regression p2-high Escalation, on top of current planning, release blocker labels Mar 29, 2018
@felixheidecke felixheidecke added this to the development milestone Mar 29, 2018
@felixheidecke felixheidecke requested a review from davitol March 29, 2018 10:09
@felixheidecke felixheidecke changed the title Setting css fixes Fix settings page where elements are inline when they shouldn't Mar 29, 2018
davitol
davitol approved these changes Apr 2, 2018
View reviewed changes
Copy link
Contributor

@davitol davitol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍 please backport stable10

PVince81
PVince81 approved these changes Apr 3, 2018
View reviewed changes
Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CSS only change, ignoring CI

@PVince81 PVince81 merged commit 1fda258 into master Apr 3, 2018
@PVince81 PVince81 deleted the setting-css-fixes branch April 3, 2018 07:12
This was referenced Apr 3, 2018
Merged
Closed
@lock
Copy link

lock bot commented Jul 31, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@PVince81 PVince81 PVince81 approved these changes

@davitol davitol davitol approved these changes

Assignees
No one assigned
Labels
3 - To Review p2-high Escalation, on top of current planning, release blocker regression settings:admin Type:Bug
Projects
None yet
Milestone
10.0.8
Development

Successfully merging this pull request may close these issues.
3 participants
@felixheidecke @PVince81 @davitol