Changes updated by rewriting config.php should sent events #31106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When changes updated by rewriting config.php, for example using method writeData() should also be logged. This change would help to log these data. An example is updating email settings from UI. Signed-off-by: Sujith H <[email protected]>
sharidas
force-pushed
the
fix-config-massupdate
branch
from
ac17373 to
62979f1
Compare
Codecov Report
@@ Coverage Diff @@
## master #31106 +/- ##
============================================
+ Coverage 62.52% 62.53% +<.01%
- Complexity 18274 18277 +3
============================================
Files 1147 1147
Lines 68428 68442 +14
Branches 1234 1234
============================================
+ Hits 42787 42801 +14
Misses 25280 25280
Partials 361 361
Continue to review full report at Codecov.
|
11 tasks
|
Stable10 PR: #31107 |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When changes updated by rewriting config.php, for example
using method writeData() should also be logged. This change
would help to log these data. An example is updating
email settings from UI.
Signed-off-by: Sujith H [email protected]
Description
When config rewrite happens with
setValues(), the symfony events are not triggered for config changes. The config.php rewrite happens. Events should be triggered for the changes that happened.Related Issue
Motivation and Context
When config rewrite happens with
setValues(), the symfony events are not triggered for config changes. The config.php rewrite happens. Events should be triggered for the changes that happened.How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: