Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly align three button dialogs #31141

Merged
merged 1 commit into from
Apr 16, 2018
Merged

Conversation

felixheidecke
Copy link
Contributor

@felixheidecke felixheidecke commented Apr 16, 2018

Description

Properly aligns three button setup in dialogs

Screenshots (if appropriate):

oihrfhlkwndefkln

Tested in IE11, FF & Chrome

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code makes sense 👍

@codecov
Copy link

codecov bot commented Apr 16, 2018

Codecov Report

Merging #31141 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #31141   +/-   ##
=========================================
  Coverage     62.52%   62.52%           
  Complexity    18274    18274           
=========================================
  Files          1147     1147           
  Lines         68428    68428           
  Branches       1234     1234           
=========================================
  Hits          42787    42787           
  Misses        25280    25280           
  Partials        361      361
Flag Coverage Δ Complexity Δ
#javascript 52.05% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 63.72% <ø> (ø) 18274 <ø> (ø) ⬇️
Impacted Files Coverage Δ Complexity Δ
core/js/sharedialoglinkshareview.js 82.05% <ø> (ø) 0 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5750819...8bb7c03. Read the comment docs.

@phil-davis
Copy link
Contributor

Backport stable10 #31147

@PVince81 PVince81 deleted the align-three-button-dialog branch April 16, 2018 19:30
@lock
Copy link

lock bot commented Jul 31, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants