Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix default lang code example #31258

Merged
merged 1 commit into from
Apr 24, 2018
Merged

Fix default lang code example #31258

merged 1 commit into from
Apr 24, 2018

Conversation

tomneedham
Copy link
Contributor

@tomneedham tomneedham commented Apr 24, 2018 •
edited
Loading

Description

otherwise translations that overwrite strings on login dont work

Related Issue

Motivation and Context

broken themes that try to overwrite strings on login

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@tomneedham tomneedham added this to the development milestone Apr 24, 2018
@tomneedham tomneedham self-assigned this Apr 24, 2018
PVince81
PVince81 approved these changes Apr 24, 2018
View reviewed changes
Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81 PVince81 merged commit 9329093 into master Apr 24, 2018
@PVince81 PVince81 deleted the fix-lang-code branch April 24, 2018 13:50
@phil-davis phil-davis mentioned this pull request May 16, 2018
Merged
@phil-davis
Copy link
Contributor

Backport stable10 #31448

@PVince81 PVince81 modified the milestones: development, QA Jun 13, 2018
@lock
Copy link

lock bot commented Jul 31, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@PVince81 PVince81 PVince81 approved these changes

Assignees

@tomneedham tomneedham

Labels
3 - To Review
Projects
None yet
Milestone
10.0.9
Development

Successfully merging this pull request may close these issues.
3 participants
@tomneedham @phil-davis @PVince81