Add a new admin section for Imprint and Privacy Policy settings #31552

VicDeo · 2018-05-28T18:15:24Z

Description

PHP backend to add links to Imprint and Privacy Policy

Related Issue

https://github.com/owncloud/enterprise/issues/2537

Motivation and Context

Allows admin to specify a links to privacy policy or imprint

How Has This Been Tested?

By visiting settings -> admin ->general and setting/resetting the controls
CLI:
php occ config:app:get core legal.imprint_url
php occ config:app:get core legal.privacy_policy_url
php occ config:app:set core legal.imprint_url new_value
php occ config:app:set core legal.privacy_policy_url new_value

Screenshots (if appropriate):

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

My code follows the code style of this project.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have read the CONTRIBUTING document.
I have added tests to cover my changes.
All new and existing tests passed.

codecov · 2018-05-28T18:46:10Z

Codecov Report

Merging #31552 into master will increase coverage by 0.02%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master   #31552      +/-   ##
============================================
+ Coverage     62.87%   62.89%   +0.02%     
- Complexity    18410    18418       +8     
============================================
  Files          1151     1154       +3     
  Lines         69114    69157      +43     
  Branches       1260     1260              
============================================
+ Hits          43456    43499      +43     
  Misses        25289    25289              
  Partials        369      369

Flag	Coverage Δ	Complexity Δ
#javascript	`52.39% <ø> (ø)`	`0 <ø> (ø)`	⬇️
#phpunit	`64.1% <100%> (+0.02%)`	`18418 <8> (+8)`	⬆️

Impacted Files	Coverage Δ	Complexity Δ
settings/routes.php	`100% <ø> (ø)`	`0 <0> (ø)`	⬇️
lib/private/Settings/SettingsManager.php	`72.72% <100%> (+0.17%)`	`44 <0> (ø)`	⬇️
settings/Controller/LegalSettingsController.php	`100% <100%> (ø)`	`3 <3> (?)`
settings/Panels/Admin/Legal.php	`100% <100%> (ø)`	`4 <4> (?)`
settings/templates/panels/admin/legal.php	`100% <100%> (ø)`	`0 <0> (?)`
settings/Application.php	`55.62% <100%> (+2.03%)`	`34 <1> (+1)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cebbb4e...91a9d68. Read the comment docs.

DeepDiver1975 · 2018-05-29T07:01:29Z

settings/Controller/LegalSettingsController.php

+	 * @return array
+	 */
+	public function setPrivacyPolicyUrl($privacy_policy) {
+		$this->config->setSystemValue(


👎 never write to configuration.php from webui . Think about clusteted Setups.

Either Store in DB or don't offer a was to Set via ui/occ

@DeepDiver1975 thanks for heads up

also: no underscores in variable names

ok, got it: don't do in your panel controller what other panels/controllers do :)

mmattel · 2018-05-29T07:35:52Z

to be filled in --> some description please
Add a new admin section --> Add a new admin section for legal content

values are stored into DB now

michaelstingl · 2018-05-29T13:02:11Z

@VicDeo Could post a screenshot?

VicDeo · 2018-05-29T15:30:26Z

@michaelstingl updated the PR description

mmattel · 2018-05-29T15:38:43Z

Documentation relevant !

PVince81 · 2018-06-06T16:24:47Z

Style of the input fields doesn't look so nice but then looking at other ones there doesn't seem to be a proper convention for how they should look like.

@VicDeo Many such fields have a colon : after the label, maybe just add that and it will look nicer. Or move the input fields to the next row.

Thoughts @felixheidecke ?

PVince81

@VicDeo please add a colon to the label and I think we can merge this.

Then we carry on with other updates in separate PRs

VicDeo · 2018-06-06T16:49:08Z

@PVince81 added

PVince81

Colon all the things ! 👍

VicDeo · 2018-06-06T18:35:46Z

Stable10: #31666

felixheidecke · 2018-06-07T16:23:05Z

@VicDeo … I need help getting $this->config->getAppValue('core', 'legal.imprint_url', '') to work in lib/private/legacy/defaults.php. I'm more of a JS guy :-P

Tried use OCP\IConfig; and referencing it in the constructor … buuuuut nothing happens. Can you point me to the right approach?

VicDeo · 2018-06-07T16:49:32Z

@felixheidecke

I need help getting $this->config->getAppValue('core', 'legal.imprint_url', '') to work in lib/private/legacy/defaults.php.

Trying to resolve the same task (passing links into templates) for emails in my local branch at the moment, will ping you after push

VicDeo · 2018-06-07T17:47:27Z

@felixheidecke here you go af2a6ed

settermjd · 2018-07-05T14:02:14Z

@VicDeo, I just attempted to use it and encountered the following error:

./occ config:app:set core legal.imprint_url https://localhost:8060/impressum
                                                                  
  Too many arguments, expected arguments "command" "app" "name".  

config:app:set [--output [OUTPUT]] [--value VALUE] [--update-only] [--] <app> <name>

./occ config:app:set core legal.imprint_url and ./occ config:app:get core legal.privacy_policy_url work. However, I can also run ./occ config:app:get core legal. and no error or message is displayed.

phil-davis · 2018-07-05T14:51:05Z

For set, it needs --value in the command.

lock · 2019-07-30T12:02:41Z

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

VicDeo added the 2 - Developing label May 28, 2018

VicDeo added this to the development milestone May 28, 2018

VicDeo self-assigned this May 28, 2018

VicDeo force-pushed the e2537 branch 2 times, most recently from b0c6064 to b94f064 Compare May 28, 2018 22:09

DeepDiver1975 previously requested changes May 29, 2018

View reviewed changes

PVince81 changed the title ~~Add a new admin section~~ Add a new admin section for Imprint and Privacy Policy settings May 29, 2018

VicDeo force-pushed the e2537 branch from b94f064 to 7752178 Compare May 29, 2018 11:51

VicDeo force-pushed the e2537 branch from 7752178 to 0dc9477 Compare May 29, 2018 14:33

VicDeo added enhancement p2-high Escalation, on top of current planning, release blocker labels May 29, 2018

mmattel mentioned this pull request May 29, 2018

Documentation for new admin section and theme requirements for Imprint and Privacy Policy settings owncloud-archive/documentation#4172

Closed

PVince81 assigned felixheidecke Jun 6, 2018

PVince81 reviewed Jun 6, 2018

View reviewed changes

PVince81 unassigned felixheidecke Jun 6, 2018

Add a new admin section

91a9d68

VicDeo force-pushed the e2537 branch from 0dc9477 to 91a9d68 Compare June 6, 2018 16:45

PVince81 approved these changes Jun 6, 2018

View reviewed changes

PVince81 added backport-request 3 - To Review and removed 2 - Developing labels Jun 6, 2018

VicDeo merged commit a4136a0 into master Jun 6, 2018

VicDeo deleted the e2537 branch June 6, 2018 18:29

VicDeo mentioned this pull request Jun 6, 2018

[Stable10] Add a new admin section for Imprint and Privacy Policy settings #31666

Merged

9 tasks

VicDeo removed the backport-request label Jun 6, 2018

PVince81 modified the milestones: development, QA Jun 13, 2018

lock bot locked as resolved and limited conversation to collaborators Jul 30, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add a new admin section for Imprint and Privacy Policy settings #31552

Add a new admin section for Imprint and Privacy Policy settings #31552

VicDeo commented May 28, 2018 •

edited

Loading

codecov bot commented May 28, 2018 •

edited

Loading

DeepDiver1975 May 29, 2018

VicDeo May 29, 2018

PVince81 May 29, 2018

VicDeo May 29, 2018

mmattel commented May 29, 2018

michaelstingl commented May 29, 2018

VicDeo commented May 29, 2018

mmattel commented May 29, 2018

PVince81 commented Jun 6, 2018

PVince81 left a comment

VicDeo commented Jun 6, 2018

PVince81 left a comment

VicDeo commented Jun 6, 2018

felixheidecke commented Jun 7, 2018 •

edited

Loading

VicDeo commented Jun 7, 2018

VicDeo commented Jun 7, 2018

settermjd commented Jul 5, 2018 •

edited

Loading

phil-davis commented Jul 5, 2018

lock bot commented Jul 30, 2019

Add a new admin section for Imprint and Privacy Policy settings #31552

Add a new admin section for Imprint and Privacy Policy settings #31552

Conversation

VicDeo commented May 28, 2018 • edited Loading

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Checklist:

codecov bot commented May 28, 2018 • edited Loading

Codecov Report

DeepDiver1975 May 29, 2018

Choose a reason for hiding this comment

VicDeo May 29, 2018

Choose a reason for hiding this comment

PVince81 May 29, 2018

Choose a reason for hiding this comment

VicDeo May 29, 2018

Choose a reason for hiding this comment

mmattel commented May 29, 2018

michaelstingl commented May 29, 2018

VicDeo commented May 29, 2018

mmattel commented May 29, 2018

PVince81 commented Jun 6, 2018

PVince81 left a comment

Choose a reason for hiding this comment

VicDeo commented Jun 6, 2018

PVince81 left a comment

Choose a reason for hiding this comment

VicDeo commented Jun 6, 2018

felixheidecke commented Jun 7, 2018 • edited Loading

VicDeo commented Jun 7, 2018

VicDeo commented Jun 7, 2018

settermjd commented Jul 5, 2018 • edited Loading

phil-davis commented Jul 5, 2018

lock bot commented Jul 30, 2019

VicDeo commented May 28, 2018 •

edited

Loading

codecov bot commented May 28, 2018 •

edited

Loading

felixheidecke commented Jun 7, 2018 •

edited

Loading

settermjd commented Jul 5, 2018 •

edited

Loading