Add version restore tests when sharee has moved the shared folder or file

[phil-davis]

Description

Add test cases for when a sharee receives a file or folder, then moves that file or folder and then tries to restore old versions.

Refactor some existing tests to check the version recovery a bit more cleanly.

Related Issue

#31681

Motivation and Context

Some issues have been reported when the sharee (receiver of a shared file or folder) moves the received share, then tries to restore an old version. Make some tests to check this behavior.

How Has This Been Tested?

Local API acceptance test run

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• acceptance test enhancement

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.

[PVince81]

@phil-davis please add another scenario where the source shared file is in "/outgoing/sharefile.txt" and where "outgoing/sharefile.txt" is shared with "user1". This would match the steps from #31681

[phil-davis]

done - that scenario also passes. so I expect this stuff is OK in master for things that use these endpoints.

[PVince81]

yes, it is ok on master and also my manual test doesn't reproduce the issue on stable10 backport of object store: #31050

let's merge this PR and backport it then

[codecov]

Codecov Report

Merging #31680 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #31680   +/-   ##
=========================================
  Coverage     62.89%   62.89%           
  Complexity    18418    18418           
=========================================
  Files          1154     1154           
  Lines         69157    69157           
  Branches       1260     1260           
=========================================
  Hits          43499    43499           
  Misses        25289    25289           
  Partials        369      369

Flag	Coverage Δ	Complexity Δ
#javascript	52.39% <ø> (ø)	0 <ø> (ø)	⬇️
#phpunit	64.1% <ø> (ø)	18418 <ø> (ø)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 649c57c...06350c2. Read the comment docs.

[PVince81]

👍 please backport

[phil-davis]

Backported to #31050 object store changes

[PVince81]

@phil-davis can you also put them in a temp PR directly to stable10 to confirm the test will fail ? (or run it locally)

[phil-davis]

I will look and see what test step code is needed out of the object-store backport, and if the used endpoints work in "raw" stable10 ...
(I am not sure how it came to be that the whole dav-versions.feature file ended up in that object-store backport)

[PVince81]

(I am not sure how it came to be that the whole dav-versions.feature file ended up in that object-store backport)

@phil-davis I think dav-versions never existed before and got written from scratch for the object store part, because object store work provided new API endpoints for versions. So the tests in questions (at least the steps) can only work with that API endpoint, which is also provided somewhere in this PR.

We cannot easily move that directly to stable10 without rewriting the steps to use the old private APIs... so better leave it here where it belongs.

[phil-davis]

Yes, I just found that in "raw" stable10 I am getting:

     │ object(Sabre\HTTP\Response)#2177 (5) {
      │   ["status":protected]=>
      │   int(404)
      │   ["statusText":protected]=>
      │   string(9) "Not Found"
      │   ["body":protected]=>
      │   string(222) "<?xml version="1.0" encoding="utf-8"?>
      │ <d:error xmlns:d="DAV:" xmlns:s="http://sabredav.org/ns">
      │   <s:exception>Sabre\DAV\Exception\NotFound</s:exception>
      │   <s:message>File not found: meta in 'root'</s:message>
      │ </d:error>

The test code accesses a meta endpoint which does not exist yet in stable10

[PVince81]

@phil-davis argh, indeed. That's the endpoint that the backport brings in for the version changes.

So we couldn't make this test work with the old API without changing the steps to talk to the old private API. Ok, let's leave this then.

[phil-davis]

As a separate thing tomorrow morning, I will see if I can make a version restore test in the webUI that will go through the described steps in the issue. I think we have some webUI restore steps already, so it might be quite easy (famous last words) to construct a scenario that fails. That would provide something that a dev can use to confirm a fix.

[PVince81]

great plan, thanks

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.