-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Put defaultMailHeaderColor back #31701
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 sadly no unit test caught this ?
@PVince81 AFAIK It's a matter of style. PHP emits a notice (depending on php.ini) and consider missing property to be public. |
Codecov Report
@@ Coverage Diff @@
## master #31701 +/- ##
=========================================
Coverage 62.91% 62.91%
Complexity 18424 18424
=========================================
Files 1156 1156
Lines 69184 69184
Branches 1260 1260
=========================================
Hits 43527 43527
Misses 25288 25288
Partials 369 369
Continue to review full report at Codecov.
|
Needs to be in with the other PR backport, I guess. |
Already in #31699 |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
this line was unintentionally removed in #31683