Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SharingBlacklistTest setGetBlacklistedReceiverGroupsProvider #31867

Merged
merged 1 commit into from
Jun 21, 2018

Conversation

phil-davis
Copy link
Contributor

Description

Remove invalid $ in setGetBlacklistedReceiverGroupsProvider array.

Motivation and Context

Noticed in drone logs, e.g. https://drone.owncloud.com/owncloud/core/8097/115

[PHP Notice:  Undefined variable: group3 in /drone/src/apps/files_sharing/tests/SharingBlacklistTest.php on line 47]
PHPUnit 5.7.27 by Sebastian Bergmann and contributors.

Runtime:       PHPDBG 7.1.18-1+ubuntu16.04.1+deb.sury.org+1
Configuration: /drone/src/tests/phpunit-autotest.xml

............................................................. 61 / 9155 ( 0%)

How Has This Been Tested?

CI knows what to do

Types of changes

  • Bug fix (non-breaking change which fixes an issue) - to unit tests only
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@phil-davis
Copy link
Contributor Author

Introduced in #31672
Needs to be cherry-picked into wherever that is backported - looks like #31740 @jvillafanez

@codecov
Copy link

codecov bot commented Jun 21, 2018

Codecov Report

Merging #31867 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #31867   +/-   ##
=========================================
  Coverage     63.27%   63.27%           
  Complexity    18479    18479           
=========================================
  Files          1161     1161           
  Lines         69377    69377           
  Branches       1261     1261           
=========================================
  Hits          43895    43895           
  Misses        25112    25112           
  Partials        370      370
Flag Coverage Δ Complexity Δ
#javascript 52.47% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 64.5% <ø> (ø) 18479 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7026417...663acc0. Read the comment docs.

Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

masterpiece approved 👍

@PVince81 PVince81 merged commit 7549002 into master Jun 21, 2018
@PVince81 PVince81 deleted the fix-SharingBlacklistTest branch June 21, 2018 16:43
@phil-davis
Copy link
Contributor Author

Has to be the smallest bugfix ever - 8-bit delete.

@PVince81
Copy link
Contributor

next achievement will be for "1-bit" delete 😉

@phil-davis
Copy link
Contributor Author

For backport, commit added to https://github.com/owncloud/core/pull/31740/commits

@PVince81
Copy link
Contributor

seems the commit got lost in a rebase or something, I'll make a new PR

@PVince81
Copy link
Contributor

stable10: #32501

@phil-davis next time I suggest you add a comment on the target PR to make sure the PR owner notices and hopefully doesn't rebase and destroy the commit

@lock lock bot locked as resolved and limited conversation to collaborators Aug 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants