Change e-mail validation regex to accept subdomains with hyphens.

[micbar]

Description

The filter regex which helps to validate the entered e-mail addresses does not accept subdomains with hyphens.

Steps to reproduce

1. Configure ownCloud to allow Users to send notification emails while sharing
2. Share something via public link
3. Send link as e-mail
4. Enter e-mail address

Expected behaviour

E-Mail address is being added to the field

Actual behaviour

Some E-Mail addresses with "-" charakter in the second subdomain get rejected / could not be added.

Examples - working

• [email protected]
• [email protected]
• [email protected]

Examples - not working

• [email protected]
• [email protected]

Related Issue

• Fixes owncloud/enterprise#2773

Motivation and Context

This has been discovered by a customer whose domains all contain a second subdomain with a hyphen

How Has This Been Tested?

• this has been tested manually and
• and within a regex tester.

New Regex, proposed solution

^[A-Za-z0-9\._%+-]+@(?:[A-Za-z0-9-]+\.)+[a-z]{2,}$

• At the beginning of the string: all letters, numbers, dots, and %_+-charakters
• @ charakter
• after the @ charakter allow all numbers and letters and hyphens, but only single occurrances of dots, so ".." is not possible.
• the toplevel domain must be 2 charakters at least.

Screenshots (if appropriate):

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Technical debt
• Tests

Checklist:

• Code changes
• Unit tests added
• Acceptance tests added
• Documentation ticket raised:

Open tasks:

• Backport (if applicable set "backport-request" label and remove when the backport was done)

[codecov]

Codecov Report

Merging #32240 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master   #32240      +/-   ##
============================================
+ Coverage     64.01%   64.01%   +<.01%     
  Complexity    18559    18559              
============================================
  Files          1171     1171              
  Lines         69834    69834              
  Branches       1267     1267              
============================================
+ Hits          44704    44706       +2     
+ Misses        24761    24758       -3     
- Partials        369      370       +1

Flag	Coverage Δ	Complexity Δ
#javascript	52.84% <100%> (+0.02%)	0 <0> (ø)	⬇️
#phpunit	65.29% <ø> (ø)	18559 <ø> (ø)	⬇️

Impacted Files	Coverage Δ	Complexity Δ
core/js/sharedialogmailview.js	62.37% <100%> (+1.98%)	0 <0> (ø)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13b3d02...6585610. Read the comment docs.

[felixboehm]

would this work?
[email protected]

[micbar]

@felixboehm
i checked your mail address. It will pass the check.

If you accidently put two dots in the address, it will fail verification.
[email protected]..xyz

[micbar]

@PVince81 after conversation in the chat, we need your feedback on this.

[DeepDiver1975]

I'd be happy to see a unit test covering the various samples of email addresses passing the regex.

[DeepDiver1975]

squash commits please

[micbar]

ok, i accidently committed the wrong file

[micbar]

complete mess :-(

[micbar]

sorry for the noise...

[PVince81]

👍

[PVince81]

@micbar please backport to stable10

[phil-davis]

Backport stable10 #32281