Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use createPositionalParameter() #32384

Merged
merged 1 commit into from
Aug 22, 2018

Conversation

DeepDiver1975
Copy link
Member

Description

Related Issue

How Has This Been Tested?

  • unit tests

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

Open tasks:

  • Backport (if applicable set "backport-request" label and remove when the backport was done)

@codecov
Copy link

codecov bot commented Aug 20, 2018

Codecov Report

Merging #32384 into master will not change coverage.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #32384   +/-   ##
=========================================
  Coverage     64.03%   64.03%           
  Complexity    18579    18579           
=========================================
  Files          1171     1171           
  Lines         69876    69876           
  Branches       1267     1267           
=========================================
  Hits          44747    44747           
  Misses        24759    24759           
  Partials        370      370
Flag Coverage Δ Complexity Δ
#javascript 52.84% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.31% <66.66%> (ø) 18579 <0> (ø) ⬇️
Impacted Files Coverage Δ Complexity Δ
lib/private/Files/Type/Loader.php 77.96% <0%> (ø) 15 <0> (ø) ⬇️
lib/private/User/AccountMapper.php 80.34% <100%> (ø) 31 <0> (ø) ⬇️
...iles_sharing/lib/Command/CleanupRemoteStorages.php 84.09% <100%> (ø) 15 <0> (ø) ⬇️
lib/private/SystemTag/SystemTagManager.php 95.6% <100%> (ø) 43 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d30569...d2b7d17. Read the comment docs.

Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see all touched code has unit tests, so should be fine 👍

@PVince81 PVince81 merged commit d743ffd into master Aug 22, 2018
@PVince81 PVince81 deleted the bugfix/use-createPositionalParameter-with-like branch August 22, 2018 10:34
@PVince81
Copy link
Contributor

@DeepDiver1975 please backport

@phil-davis
Copy link
Contributor

Backport stable10 #32412

@lock lock bot locked as resolved and limited conversation to collaborators Aug 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants