Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update config.sample.php to fix a broken link #33516

Merged
merged 1 commit into from
Nov 14, 2018
Merged

Conversation

mmattel
Copy link
Contributor

@mmattel mmattel commented Nov 14, 2018

Description

This is a small update to fix link issues found via documentation (docs repro).

  • the tocker page has a new location (the timestamp was removed from the url)
  • some quotes, backticks corrected

Related Issue

  • none, found via broken linkchecker work in docs repro

Motivation and Context

Fix broken link

How Has This Been Tested?

Link tested

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
    (will be transferred to docs automatically with the transportation script)

Open tasks:

  • Backport (if applicable set "backport-request" label and remove when the backport was done)

This is a small update to fix link issues found via documentation (docs repro).
- the tocker page has a new location (the timestamp was removed from the url)
- some quotes, backticks corrected
@codecov
Copy link

codecov bot commented Nov 14, 2018

Codecov Report

Merging #33516 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #33516   +/-   ##
=========================================
  Coverage     64.08%   64.08%           
  Complexity    18303    18303           
=========================================
  Files          1192     1192           
  Lines         69147    69147           
  Branches       1277     1277           
=========================================
  Hits          44312    44312           
  Misses        24463    24463           
  Partials        372      372
Flag Coverage Δ Complexity Δ
#javascript 52.91% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.37% <ø> (ø) 18303 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc169fb...e85cf01. Read the comment docs.

@mmattel mmattel merged commit 4fdd930 into master Nov 14, 2018
@mmattel mmattel deleted the mmattel-patch-1 branch November 14, 2018 14:04
@phil-davis
Copy link
Contributor

Backport stable10 #33518

@lock lock bot locked as resolved and limited conversation to collaborators Nov 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants