Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update activity listener for static tags #33862

Merged
merged 1 commit into from
Dec 11, 2018
Merged

Conversation

sharidas
Copy link
Contributor

@sharidas sharidas commented Dec 11, 2018

Update activity listener for static tags

Signed-off-by: Sujith H [email protected]

Description

Add static tags to the activity listeners. Creation, updation activity of the static tags should be seen in the activity app, just like other tags: restricted, visible and invisible.

Related Issue

  • Fixes <issue_link>

Motivation and Context

Add static tags to the activity listener.

How Has This Been Tested?

  • Tested in the UI as shown:
    gifrecord_2018-12-11_224740

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • Backport (if applicable set "backport-request" label and remove when the backport was done)

Update activity listener for static tags

Signed-off-by: Sujith H <[email protected]>
@sharidas sharidas added this to the development milestone Dec 11, 2018
@sharidas sharidas self-assigned this Dec 11, 2018
@codecov
Copy link

codecov bot commented Dec 11, 2018

Codecov Report

Merging #33862 into master will increase coverage by 0.07%.
The diff coverage is 80%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #33862      +/-   ##
============================================
+ Coverage     64.35%   64.42%   +0.07%     
- Complexity    18309    18318       +9     
============================================
  Files          1195     1197       +2     
  Lines         69255    69260       +5     
  Branches       1276     1276              
============================================
+ Hits          44566    44621      +55     
+ Misses        24317    24267      -50     
  Partials        372      372
Flag Coverage Δ Complexity Δ
#javascript 52.98% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.75% <80%> (+0.08%) 18318 <6> (+9) ⬆️
Impacted Files Coverage Δ Complexity Δ
apps/systemtags/lib/Activity/Listener.php 16.84% <100%> (+16.84%) 31 <0> (+2) ⬆️
apps/systemtags/lib/Activity/Extension.php 15% <100%> (+15%) 47 <0> (+1) ⬆️
apps/systemtags/tests/ListenerTest.php 75% <75%> (ø) 3 <3> (?)
apps/systemtags/tests/ExtensionTest.php 81.81% <81.81%> (ø) 3 <3> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f51318...02ad0b1. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Dec 11, 2018

Codecov Report

Merging #33862 into master will increase coverage by 0.07%.
The diff coverage is 80%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #33862      +/-   ##
============================================
+ Coverage     64.35%   64.42%   +0.07%     
- Complexity    18309    18318       +9     
============================================
  Files          1195     1197       +2     
  Lines         69255    69260       +5     
  Branches       1276     1276              
============================================
+ Hits          44566    44621      +55     
+ Misses        24317    24267      -50     
  Partials        372      372
Flag Coverage Δ Complexity Δ
#javascript 52.98% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.75% <80%> (+0.08%) 18318 <6> (+9) ⬆️
Impacted Files Coverage Δ Complexity Δ
apps/systemtags/lib/Activity/Listener.php 16.84% <100%> (+16.84%) 31 <0> (+2) ⬆️
apps/systemtags/lib/Activity/Extension.php 15% <100%> (+15%) 47 <0> (+1) ⬆️
apps/systemtags/tests/ListenerTest.php 75% <75%> (ø) 3 <3> (?)
apps/systemtags/tests/ExtensionTest.php 81.81% <81.81%> (ø) 3 <3> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f51318...02ad0b1. Read the comment docs.

@sharidas sharidas changed the title [WIP] Update activity listener for static tags Update activity listener for static tags Dec 11, 2018
@sharidas
Copy link
Contributor Author

The change is minimal. The context behind this PR:

  • static tags creation, deletion, update should be added to activity listeners, just like other tags: restricted, visible and invisible.

Review is required for this PR.

@sharidas sharidas requested a review from PVince81 December 11, 2018 17:27
Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81 PVince81 merged commit 6bfd070 into master Dec 11, 2018
@delete-merged-branch delete-merged-branch bot deleted the systemtag-listener-work branch December 11, 2018 21:42
@PVince81
Copy link
Contributor

@sharidas please backport

@sharidas
Copy link
Contributor Author

Backported to stable10: #33864

@lock lock bot locked as resolved and limited conversation to collaborators Dec 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants