Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Stable10] Add pause of one second before delete in acceptance test steps #34066

Merged
merged 1 commit into from
Jan 8, 2019

Conversation

dpakach
Copy link
Contributor

@dpakach dpakach commented Jan 8, 2019

Stable 10 Backport for #34063

@dpakach dpakach force-pushed the stable10-refactor-upload-delete-sleep branch from 8ce1d27 to 0ed0ef8 Compare January 8, 2019 07:41
@codecov
Copy link

codecov bot commented Jan 8, 2019

Codecov Report

Merging #34066 into stable10 will increase coverage by 18.38%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             stable10   #34066       +/-   ##
===============================================
+ Coverage       45.18%   63.56%   +18.38%     
- Complexity          0    19109    +19109     
===============================================
  Files             116     1264     +1148     
  Lines           11458    75147    +63689     
  Branches         1286     1286               
===============================================
+ Hits             5177    47770    +42593     
- Misses           5905    27001    +21096     
  Partials          376      376
Flag Coverage Δ Complexity Δ
#javascript 53.32% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 64.66% <ø> (+33.64%) 19109 <ø> (+19109) ⬆️
Impacted Files Coverage Δ Complexity Δ
apps/files_external/lib/config.php 10.71% <0%> (-20.87%) 19% <0%> (+19%)
apps/updatenotification/templates/admin.php 0% <0%> (ø) 0% <0%> (?)
lib/private/Encryption/Keys/Storage.php 91.45% <0%> (ø) 48% <0%> (?)
lib/private/App/CodeChecker/NodeVisitor.php 95.04% <0%> (ø) 54% <0%> (?)
lib/private/RedisFactory.php 0% <0%> (ø) 19% <0%> (?)
apps/dav/lib/Avatars/AvatarNode.php 72% <0%> (ø) 9% <0%> (?)
...s/dav/appinfo/Migrations/Version20170202213905.php 21.05% <0%> (ø) 12% <0%> (?)
apps/dav/lib/Upload/ChunkLocationProvider.php 100% <0%> (ø) 4% <0%> (?)
apps/files/lib/AppInfo/Application.php 32.43% <0%> (ø) 2% <0%> (?)
apps/systemtags/list.php 0% <0%> (ø) 0% <0%> (?)
... and 1140 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d170c47...0ed0ef8. Read the comment docs.

@codecov
Copy link

codecov bot commented Jan 8, 2019

Codecov Report

Merging #34066 into stable10 will increase coverage by 0.25%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             stable10   #34066      +/-   ##
==============================================
+ Coverage       63.31%   63.56%   +0.25%     
  Complexity      19109    19109              
==============================================
  Files            1264     1264              
  Lines           75147    75147              
  Branches         1286     1286              
==============================================
+ Hits            47581    47770     +189     
+ Misses          27190    27001     -189     
  Partials          376      376
Flag Coverage Δ Complexity Δ
#javascript 53.32% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 64.66% <ø> (+0.27%) 19109 <ø> (ø) ⬇️
Impacted Files Coverage Δ Complexity Δ
lib/private/Share/Share.php 71.1% <0%> (+0.06%) 502% <0%> (ø) ⬇️
lib/private/DB/QueryBuilder/QueryBuilder.php 91.34% <0%> (+0.48%) 68% <0%> (ø) ⬇️
lib/private/DB/MDB2SchemaWriter.php 93.75% <0%> (+1.04%) 34% <0%> (ø) ⬇️
lib/private/DB/MDB2SchemaManager.php 91.22% <0%> (+1.75%) 17% <0%> (ø) ⬇️
lib/private/Files/Cache/Cache.php 97.56% <0%> (+1.82%) 105% <0%> (ø) ⬇️
lib/private/AllConfig.php 93.15% <0%> (+2.05%) 43% <0%> (ø) ⬇️
lib/private/Repair/RepairInvalidShares.php 97.26% <0%> (+2.73%) 17% <0%> (ø) ⬇️
lib/private/Repair/RepairMismatchFileCachePath.php 96.89% <0%> (+3.48%) 51% <0%> (ø) ⬇️
lib/private/DB/ConnectionFactory.php 82.89% <0%> (+3.94%) 21% <0%> (ø) ⬇️
lib/private/DB/Adapter.php 88.88% <0%> (+6.17%) 25% <0%> (ø) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d170c47...0ed0ef8. Read the comment docs.

@phil-davis phil-davis merged commit 58f2eeb into stable10 Jan 8, 2019
@delete-merged-branch delete-merged-branch bot deleted the stable10-refactor-upload-delete-sleep branch January 8, 2019 11:40
@lock lock bot locked as resolved and limited conversation to collaborators Jan 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants