Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the testing app to not be in the default apps folder #34193

Merged
merged 1 commit into from
Jan 21, 2019

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Jan 21, 2019

Description

Be smart about looking for the testing app skeleton directories within testing/data. Do not assume that they will be found under the apps folder.

Issue

#34194

Motivation and Context

See issue.

How Has This Been Tested?

Local acceptance test runs with the testing app installed in apps-external

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • Backport (if applicable set "backport-request" label and remove when the backport was done)

@codecov
Copy link

codecov bot commented Jan 21, 2019

Codecov Report

Merging #34193 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #34193      +/-   ##
============================================
+ Coverage     64.76%   64.76%   +<.01%     
  Complexity    18351    18351              
============================================
  Files          1198     1198              
  Lines         69467    69467              
  Branches       1281     1281              
============================================
+ Hits          44989    44993       +4     
+ Misses        24105    24101       -4     
  Partials        373      373
Flag Coverage Δ Complexity Δ
#javascript 53.09% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.12% <ø> (ø) 18351 <ø> (ø) ⬇️
Impacted Files Coverage Δ Complexity Δ
lib/private/Files/View.php 84.6% <0%> (+0.3%) 398% <0%> (ø) ⬇️
lib/private/DB/Connection.php 66.17% <0%> (+0.73%) 49% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3515439...3978dd4. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Jan 21, 2019

Codecov Report

Merging #34193 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #34193      +/-   ##
============================================
+ Coverage     64.76%   64.76%   +<.01%     
  Complexity    18351    18351              
============================================
  Files          1198     1198              
  Lines         69467    69467              
  Branches       1281     1281              
============================================
+ Hits          44989    44993       +4     
+ Misses        24105    24101       -4     
  Partials        373      373
Flag Coverage Δ Complexity Δ
#javascript 53.09% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.12% <ø> (ø) 18351 <ø> (ø) ⬇️
Impacted Files Coverage Δ Complexity Δ
lib/private/Files/View.php 84.6% <0%> (+0.3%) 398% <0%> (ø) ⬇️
lib/private/DB/Connection.php 66.17% <0%> (+0.73%) 49% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3515439...3978dd4. Read the comment docs.

@phil-davis
Copy link
Contributor Author

Backport stable10 #34196

@phil-davis phil-davis merged commit 2403843 into master Jan 21, 2019
@delete-merged-branch delete-merged-branch bot deleted the allow-testing-app-in-other-apps-path branch January 21, 2019 08:40
@lock lock bot locked as resolved and limited conversation to collaborators Jan 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants